From: Remi Lespinet Date: Tue, 30 Jun 2015 12:16:47 +0000 (+0200) Subject: send-email: minor code refactoring X-Git-Tag: v2.6.0-rc0~109^2~4 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/c46e27aa774eae2ac58f1763afe00108f3a1e5d3 send-email: minor code refactoring Group expressions in a single if statement. This avoid checking multiple time if the variable $sender is defined. Signed-off-by: Remi Lespinet Signed-off-by: Matthieu Moy Signed-off-by: Junio C Hamano --- diff --git a/git-send-email.perl b/git-send-email.perl index 228400b3e9..09ecad830f 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -774,9 +774,9 @@ sub file_declares_8bit_cte { } } -($sender) = expand_aliases($sender) if defined $sender; - -if (!defined $sender) { +if (defined $sender) { + ($sender) = expand_aliases($sender); +} else { $sender = $repoauthor || $repocommitter || ''; }