From: Jeff King <peff@peff.net>
Date: Thu, 11 Feb 2016 22:23:48 +0000 (-0500)
Subject: http-push: stop using name_path
X-Git-Tag: v2.4.11~1^2~4
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/c6bd2a1decc252d823104f9849c87ec8484b18ea?ds=sidebyside;hp=c6bd2a1decc252d823104f9849c87ec8484b18ea

http-push: stop using name_path

The graph traversal code here passes along a name_path to
build up the pathname at which we find each blob. But we
never actually do anything with the resulting names, making
it a waste of code and memory.

This usage came in aa1dbc9 (Update http-push functionality,
2006-03-07), and originally the result was passed to
"add_object" (which stored it, but didn't really use it,
either). But we stopped using that function in 1f1e895 (Add
"named object array" concept, 2006-06-19) in favor of
storing just the objects themselves.

Moreover, the generation of the name in process_tree() is
buggy. It sticks "name" onto the end of the name_path linked
list, and then passes it down again as it recurses (instead
of "entry.path"). So it's a good thing this was unused, as
the resulting path for "a/b/c/d" would end up as "a/a/a/a".

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---