From: Mark Hills <mark@pogo.org.uk>
Date: Mon, 5 May 2008 16:46:42 +0000 (+0100)
Subject: Be more careful with objects directory permissions on clone
X-Git-Tag: v1.5.6-rc0~90
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/c904bf392d7621b04c14bb9b2e93c3ed08f7e57b?ds=inline;hp=--cc

Be more careful with objects directory permissions on clone

Honour the setgid and umask when re-creating the objects directory
at the destination.

cpio in copy-pass mode aims to copy file permissions which causes this
problem and cannot be disabled. Be explicit by copying the directory
structure first, honouring the permissions at the destination, then copy
the files with 0444 permissions. This also avoids bugs in some versions
of cpio.

Signed-off-by: Mark Hills <mark@pogo.org.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

c904bf392d7621b04c14bb9b2e93c3ed08f7e57b
diff --git a/git-clone.sh b/git-clone.sh
index 8c7fc7f631..9d88d1ce60 100755
--- a/git-clone.sh
+++ b/git-clone.sh
@@ -334,7 +334,10 @@ yes)
 			fi
 		fi &&
 		cd "$repo" &&
-		find objects -depth -print | cpio $cpio_quiet_flag -pumd$l "$GIT_DIR/" || \
+		# Create dirs using umask and permissions and destination
+		find objects -type d -print | (cd "$GIT_DIR" && xargs mkdir -p) &&
+		# Copy existing 0444 permissions on content
+		find objects ! -type d -print | cpio $cpio_quiet_flag -pumd$l "$GIT_DIR/" || \
 			exit 1
 	fi
 	git-ls-remote "$repo" >"$GIT_DIR/CLONE_HEAD" || exit 1