From: Brandon Richardson Date: Thu, 7 Mar 2019 15:44:09 +0000 (-0400) Subject: commit-tree: utilize parse-options api X-Git-Tag: v2.22.0-rc0~135^2 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/cbdeab98e871bfbb45cf5095cc804ebb07054eba?hp=cbdeab98e871bfbb45cf5095cc804ebb07054eba commit-tree: utilize parse-options api Rather than parse options manually, which is both difficult to read and error prone, parse options supplied to commit-tree using the parse-options api. It was discovered that the --no-gpg-sign option was documented but not implemented in commit 70ddbd7767 (commit-tree: add missing --gpg-sign flag, 2019-01-19), and the existing implementation would attempt to translate the option as a tree oid. It was also suggested earlier in commit 55ca3f99ae (commit-tree: add and document --no-gpg-sign, 2013-12-13) that commit-tree should be migrated to utilize the parse-options api, which could help prevent mistakes like this in the future. Hence this change. Also update the documentation to better describe that mixing `-m` and `-F` options will correctly compose commit log messages in the order in which the options are given. In the process, mark various strings for translation. Signed-off-by: Brandon Richardson Signed-off-by: Junio C Hamano ---