From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date: Thu, 2 Feb 2012 09:57:23 +0000 (-0600)
Subject: vcs-svn: rename check_overflow and its arguments for clarity
X-Git-Tag: v1.7.12-rc0~41^2~11
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/ce8ebcdaf31dd56955635808bba1a6df50601563?ds=inline;hp=ce8ebcdaf31dd56955635808bba1a6df50601563

vcs-svn: rename check_overflow and its arguments for clarity

The canonical interpretation of a range a,b is as an interval [a,b),
not [a,a+b), so this function taking argument names a and b feels
unnatural.  Use more explicit names "offset" and "len" to make the
arguments' type and function clearer.

While at it, rename the function to convey that we are making sure
the sum of this offset and length do not overflow an off_t, not a
size_t.

[jn: split out from a patch from Ramsay Jones, then improved with
advice from Thomas Rast, Dmitry Ivankov, and David Barr]

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Improved-by: Dmitry Ivankov <divanorama@gmail.com>
---