From: Santiago Torres Date: Tue, 5 Apr 2016 16:07:24 +0000 (-0400) Subject: builtin/verify-tag.c: ignore SIGPIPE in gpg-interface X-Git-Tag: v2.9.0-rc0~86^2~5 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/d281b45d754477e79a8e0228c8f5ce4195079238?ds=inline;hp=d281b45d754477e79a8e0228c8f5ce4195079238 builtin/verify-tag.c: ignore SIGPIPE in gpg-interface The verify_signed_buffer() function may trigger a SIGPIPE when the GPG child process terminates early (due to a bad keyid, for example) and Git tries to write to it afterwards. Previously, ignoring SIGPIPE was done in builtin/verify-tag.c to avoid this issue. However, any other caller who wants to call verify_signed_buffer() would have to do the same. Use sigchain_push(SIGPIPE, SIG_IGN) in verify_signed_buffer(), pretty much like in sign_buffer(), so that any caller is not required to perform this task. This will avoid possible mistakes by further developers using verify_signed_buffer(). Signed-off-by: Santiago Torres Reviewed-by: Eric Sunshine Signed-off-by: Junio C Hamano ---