From: Jeff King <peff@peff.net>
Date: Thu, 9 Mar 2017 13:29:04 +0000 (-0500)
Subject: ref-filter: die on parse_commit errors
X-Git-Tag: v2.13.0-rc0~106^2~1
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/d344d1cb8a1d1bea268ec78f5d7315381a0a6c96

ref-filter: die on parse_commit errors

The tag-contains algorithm quietly returns "does not
contain" when parse_commit() fails. But a parse failure is
an indication that the repository is corrupt. We should die
loudly rather than producing a bogus result.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/ref-filter.c b/ref-filter.c
index 631978a4f9..5cb49b7c24 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -1523,9 +1523,7 @@ static enum contains_result contains_test(struct commit *candidate,
 		return CONTAINS_YES;
 	}
 
-	if (parse_commit(candidate) < 0)
-		return CONTAINS_NO;
-
+	parse_commit_or_die(candidate);
 	return CONTAINS_UNKNOWN;
 }