From: Jeff King Date: Sun, 13 Jul 2014 06:42:12 +0000 (-0400) Subject: object_as_type: set commit index X-Git-Tag: v2.1.0-rc0~12^2~1 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/d66bebcbcfa46d72bb5008e1d211c0ea87200d86 object_as_type: set commit index The point of the "index" field of struct commit is that every allocated commit would have one. It is supposed to be an invariant that whenever object->type is set to OBJ_COMMIT, we have a unique index. Commit 969eba6 (commit: push commit_index update into alloc_commit_node, 2014-06-10) covered this case for newly-allocated commits. However, we may also allocate an "unknown" object via lookup_unknown_object, and only later convert it to a commit. We must make sure that we set the commit index when we switch the type field. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- diff --git a/object.c b/object.c index b2319f6246..69fbbbf504 100644 --- a/object.c +++ b/object.c @@ -163,6 +163,8 @@ void *object_as_type(struct object *obj, enum object_type type, int quiet) if (obj->type == type) return obj; else if (obj->type == OBJ_NONE) { + if (type == OBJ_COMMIT) + ((struct commit *)obj)->index = alloc_commit_index(); obj->type = type; return obj; }