From: Ramkumar Ramachandra Date: Sun, 2 Jun 2013 14:03:41 +0000 (+0530) Subject: completion: difftool takes both revs and files X-Git-Tag: v1.8.4-rc0~167^2~1 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/d8517cc6670d4ba18e9b77a83b2481aec0edbc32?ds=inline;hp=--cc completion: difftool takes both revs and files 'git difftool' is clearly a frontend to 'git diff' and is used in exactly the same way, but it uses a misleadingly named completion function __git_complete_file. It happens to work only because it calls __git_complete_revlist_file that completes both revs and paths. Change it to use __git_complete_revlist_file, just like 'git diff'. Signed-off-by: Ramkumar Ramachandra Signed-off-by: Junio C Hamano --- d8517cc6670d4ba18e9b77a83b2481aec0edbc32 diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 1c35eef56a..1b4b0f95a9 100644 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -1294,7 +1294,7 @@ _git_difftool () return ;; esac - __git_complete_file + __git_complete_revlist_file } __git_fetch_options="