From: Jeff King <peff@peff.net>
Date: Wed, 13 Sep 2017 17:17:57 +0000 (-0400)
Subject: config: flip return value of store_write_*()
X-Git-Tag: v2.14.3~3^2~1
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/d9bd4cbb9cce9f872cc4427d1c27a62c6768b12a?hp=d9bd4cbb9cce9f872cc4427d1c27a62c6768b12a

config: flip return value of store_write_*()

The store_write_section() and store_write_pairs() functions
are basically high-level wrappers around write(). But their
return values are flipped from our usual convention, using
"1" for success and "0" for failure.

Let's flip them to follow the usual write() conventions and
update all callers. As these are local to config.c, it's
unlikely that we'd have new callers in any topics in flight
(which would be silently broken by our change). But just to
be on the safe side, let's rename them to just
write_section() and write_pairs().  That also accentuates
their relationship with write().

Signed-off-by: Jeff King <peff@peff.net>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---