From: Elia Pinto <gitter.spiros@gmail.com>
Date: Mon, 28 Apr 2014 12:57:30 +0000 (-0700)
Subject: t0300-credentials.sh: use the $( ... ) construct for command substitution
X-Git-Tag: v2.1.0-rc0~184^2~21
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/dd64267fe2151b1ea3f19b5745d0fa8321995381?hp=4d713567f9e79f738e7b309ad0222e1517871f9c

t0300-credentials.sh: use the $( ... ) construct for command substitution

The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.

The backquoted form is the traditional method for command
substitution, and is supported by POSIX.  However, all but the
simplest uses become complicated quickly.  In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.

The patch was generated by:

for _f in $(find . -name "*.sh")
do
sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done

and then carefully proof-read.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/t/t0300-credentials.sh b/t/t0300-credentials.sh
index 538ea5fb1c..57ea5a10c5 100755
--- a/t/t0300-credentials.sh
+++ b/t/t0300-credentials.sh
@@ -6,7 +6,7 @@ test_description='basic credential helper tests'
 
 test_expect_success 'setup helper scripts' '
 	cat >dump <<-\EOF &&
-	whoami=`echo $0 | sed s/.*git-credential-//`
+	whoami=$(echo $0 | sed s/.*git-credential-//)
 	echo >&2 "$whoami: $*"
 	OIFS=$IFS
 	IFS==