From: Jeff King Date: Thu, 24 Sep 2015 21:07:27 +0000 (-0400) Subject: remote-ext: simplify git pkt-line generation X-Git-Tag: v2.7.0-rc0~87^2~33 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/df1ed03a6fabf58b63b26950c71d36eff4aa25e8?hp=df1ed03a6fabf58b63b26950c71d36eff4aa25e8 remote-ext: simplify git pkt-line generation We format a pkt-line into a heap buffer, which requires manual computation of the required size, and uses some bare sprintf calls. We could use a strbuf instead, which would take care of the computation for us. But it's even easier still to use packet_write(). Besides handling the formatting and writing for us, it fixes two things: 1. Our manual max-size check used 0xFFFF, while technically LARGE_PACKET_MAX is slightly smaller than this. 2. Our packet will now be output as part of GIT_TRACE_PACKET debugging. Unfortunately packet_write() does not let us build up the buffer progressively, so we do have to repeat ourselves a little depending on the "vhost" setting, but the end result is still far more readable than the original. Since there were no tests covering this feature at all, we'll add a few into t5802. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano ---