From: Thomas Jarosch <thomas.jarosch@intra2net.com>
Date: Fri, 17 Apr 2009 12:05:11 +0000 (+0200)
Subject: Fix buffer overflow in config parser
X-Git-Tag: v1.6.1.4~8^2
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/e0b3cc0dffbc965ffa33155cbdcf8d44716c134c?ds=inline;hp=e0b3cc0dffbc965ffa33155cbdcf8d44716c134c

Fix buffer overflow in config parser

When interpreting a config value, the config parser reads in 1+ space
character(s) and puts -one- space character in the buffer as soon as
the first non-space character is encountered (if not inside quotes).

Unfortunately the buffer size check lacks the extra space character
which gets inserted at the next non-space character, resulting in
a crash with a specially crafted config entry.

The unit test now uses Java to compile a platform independent
.NET framework to output the test string in C# :o)

Read: Thanks to Johannes Sixt for the correct printf call
which replaces the perl invocation.

Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---