From: Jonas Fonseca <fonseca@diku.dk>
Date: Sat, 30 Apr 2005 03:00:40 +0000 (-0700)
Subject: [PATCH] git-fsck-cache: Gracefully handle non-commit IDs
X-Git-Tag: v0.99~696
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/e1a1388d858fa8522f187d3fdea92ff84e21528c

[PATCH] git-fsck-cache: Gracefully handle non-commit IDs

Gracefully handle non-commit IDs instead of segfaulting.

Signed-off-by: Jonas Fonseca <fonseca@diku.dk>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---

diff --git a/fsck-cache.c b/fsck-cache.c
index 280a104050..164fc2eaee 100644
--- a/fsck-cache.c
+++ b/fsck-cache.c
@@ -174,7 +174,14 @@ int main(int argc, char **argv)
 			continue;
 
 		if (!get_sha1_hex(arg, head_sha1)) {
-			struct object *obj = &lookup_commit(head_sha1)->object;
+			struct commit *commit = lookup_commit(head_sha1);
+			struct object *obj;
+
+			/* Error is printed by lookup_commit(). */
+			if (!commit)
+				continue;
+
+			obj = &commit->object;
 			obj->used = 1;
 			mark_reachable(obj, REACHABLE);
 			heads++;