From: Pavel Roskin <proski@gnu.org>
Date: Fri, 29 Jul 2005 14:49:14 +0000 (-0400)
Subject: [PATCH] mmap error handling
X-Git-Tag: v0.99.3~32
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/e35f9824159bba94eecdf22d198799701ed60940?ds=sidebyside;hp=e35f9824159bba94eecdf22d198799701ed60940

[PATCH] mmap error handling

I have reviewed all occurrences of mmap() in git and fixed three types
of errors/defects:

1) The result is not checked.
2) The file descriptor is closed if mmap() succeeds, but not when it
fails.
3) Various casts applied to -1 are used instead of MAP_FAILED, which is
specifically defined to check mmap() return value.

[jc: This is a second round of Pavel's patch.  He fixed up the problem
that close() potentially clobbering the errno from mmap, which
the first round had.]

Signed-off-by: Pavel Roskin <proski@gnu.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
---