From: Jeff King <peff@peff.net>
Date: Thu, 20 Jun 2019 07:41:42 +0000 (-0400)
Subject: khash: rename oid helper functions
X-Git-Tag: v2.23.0-rc0~66^2~2
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/e465e7c41d5104b48a16b122a666cbbfa184c25d?ds=inline;hp=e465e7c41d5104b48a16b122a666cbbfa184c25d

khash: rename oid helper functions

For use in object_id hash tables, we have oid_hash() and oid_equal().
But these are confusingly similar to the existing oideq() and the
oidhash() we plan to add to replace sha1hash().

The big difference from those functions is that rather than accepting a
const pointer to the "struct object_id", we take the arguments by value
(which is a khash internal convention). So let's make that obvious by
calling them oidhash_by_value() and oideq_by_value().

Those names are fairly horrendous to type, but we rarely need to do so;
they are passed to the khash implementation macro and then only used
internally. Callers get to use the nice kh_put_oid_map(), etc.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---