From: Stefan Beller <sbeller@google.com>
Date: Wed, 30 May 2018 17:03:02 +0000 (-0700)
Subject: submodule--helper: plug mem leak in print_default_remote
X-Git-Tag: v2.19.0-rc0~181^2~2
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/e6be8e2f9f87fbd6a4f58ac3cda4558563833088?ds=inline;hp=--cc

submodule--helper: plug mem leak in print_default_remote

Signed-off-by: Stefan Beller <sbeller@google.com>
Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
[jc: no need for remote to be const char *]
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

e6be8e2f9f87fbd6a4f58ac3cda4558563833088
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index bd250ca216..7a752dbf9d 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -55,7 +55,7 @@ static char *get_default_remote(void)
 
 static int print_default_remote(int argc, const char **argv, const char *prefix)
 {
-	const char *remote;
+	char *remote;
 
 	if (argc != 1)
 		die(_("submodule--helper print-default-remote takes no arguments"));
@@ -64,6 +64,7 @@ static int print_default_remote(int argc, const char **argv, const char *prefix)
 	if (remote)
 		printf("%s\n", remote);
 
+	free(remote);
 	return 0;
 }