From: Fabian Keil Date: Mon, 31 Jan 2011 19:29:46 +0000 (+0100) Subject: git-cvsimport.perl: Bail out right away when reading from the server fails X-Git-Tag: v1.7.4.3~8^2 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/e7cad3ccd05461b0defdef86c9d786ab6fb9fe40?ds=sidebyside;hp=e7cad3ccd05461b0defdef86c9d786ab6fb9fe40 git-cvsimport.perl: Bail out right away when reading from the server fails If the CVS server is down, this reduced the git-cvsimport output from: ssh: connect to host ijbswa.cvs.sourceforge.net port 22: Connection refused Use of uninitialized value $rep in scalar chomp at /usr/local/libexec/git-core/git-cvsimport line 369. Use of uninitialized value $rep in substitution (s///) at /usr/local/libexec/git-core/git-cvsimport line 370. Expected Valid-requests from server, but got: to the less noisy: ssh: connect to host ijbswa.cvs.sourceforge.net port 22: Connection refused Failed to read from server at /usr/local/libexec/git-core/git-cvsimport line 370. In this case a silent exit() instead of the die() would probably do, but I assume that there could be cases where the connection attempt succeeds, but reading from the server fails for other reasons. Signed-off-by: Fabian Keil Signed-off-by: Junio C Hamano ---