From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Tue, 7 May 2013 21:55:09 +0000 (-0500)
Subject: sha1_name: don't waste cycles in the @-parsing loop
X-Git-Tag: v1.8.4-rc0~180^2~5
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/e883a057a9da3c738dd6f6e2f1aa9498885ae1e8

sha1_name: don't waste cycles in the @-parsing loop

The @-parsing loop unnecessarily checks for the sequence "@{" from
(len - 2) unnecessarily.  We can safely check from (len - 4).

Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/sha1_name.c b/sha1_name.c
index 6530ddd6d8..7b59f6f4ec 100644
--- a/sha1_name.c
+++ b/sha1_name.c
@@ -445,7 +445,7 @@ static int get_sha1_basic(const char *str, int len, unsigned char *sha1)
 	/* basic@{time or number or -number} format to query ref-log */
 	reflog_len = at = 0;
 	if (len && str[len-1] == '}') {
-		for (at = len-2; at >= 0; at--) {
+		for (at = len-4; at >= 0; at--) {
 			if (str[at] == '@' && str[at+1] == '{') {
 				if (!upstream_mark(str + at, len - at)) {
 					reflog_len = (len-1) - (at+2);