From: Olga Telezhnaya <olyatelezhnaya@gmail.com>
Date: Wed, 21 Feb 2018 06:59:01 +0000 (+0000)
Subject: ref-filter: get rid of goto
X-Git-Tag: v2.17.0-rc0~29^2
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/edfb8ba06822375b08796b7b4354a94d98b05d13?hp=--cc

ref-filter: get rid of goto

Get rid of goto command in ref-filter for better readability.

Signed-off-by: Olga Telezhnaia <olyatelezhnaya@gmail.com>
Mentored-by: Christian Couder <christian.couder@gmail.com>
Mentored by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

edfb8ba06822375b08796b7b4354a94d98b05d13
diff --git a/ref-filter.c b/ref-filter.c
index 2570870439..be94766f78 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -1494,11 +1494,11 @@ static void populate_value(struct ref_array_item *ref)
 	for (i = 0; i < used_atom_cnt; i++) {
 		struct atom_value *v = &ref->value[i];
 		if (v->s == NULL)
-			goto need_obj;
+			break;
 	}
-	return;
+	if (used_atom_cnt <= i)
+		return;
 
- need_obj:
 	get_object(ref, &ref->objectname, 0, &obj);
 
 	/*