From: Jeff King Date: Tue, 5 Sep 2017 12:15:15 +0000 (-0400) Subject: ref_lock: stop leaking lock_files X-Git-Tag: v2.15.0-rc0~91^2~1 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/ee4d8e455c0981269213eccfd788a9bb9adf77d9?ds=inline;hp=ee4d8e455c0981269213eccfd788a9bb9adf77d9 ref_lock: stop leaking lock_files Since the tempfile code recently relaxed the rule that tempfile structs (and thus locks) need to hang around forever, we no longer have to leak our lock_file structs. In fact, we don't even need to heap-allocate them anymore, since their lifetime can just match that of the surrounding ref_lock (and if we forget to delete a lock, the effect is the same as before: it will eventually go away at program exit). Note that there is a check in unlock_ref() to only rollback a lock file if it has been allocated. We don't need that check anymore; we zero the ref_lock (and thus the lock_file), so at worst we pass a NULL pointer to delete_tempfile(), which considers that a noop. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano ---