From: Michael J Gruber Date: Fri, 1 Apr 2011 09:20:31 +0000 (+0200) Subject: builtin/log.c: separate default and setup of cmd_log_init() X-Git-Tag: v1.7.5.1~7^2~2 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/ef803fd4b09bca707c7c27669a2789bb050b488c?hp=ef803fd4b09bca707c7c27669a2789bb050b488c builtin/log.c: separate default and setup of cmd_log_init() cmd_log_init() sets up some default rev options and then calls setup_revisions(), so that a caller cannot set up own defaults: Either they get overriden by cmd_log_init() (if set before) or they override the command line (if set after). We even complain about this in a comment to cmd_log_reflog(). Therefore, separate the two steps so that one can still call cmd_log_init() or, alternatively, cmd_log_init_defaults() followed by cmd_log_init_finish() (and set defaults in between). No functional change so far. Signed-off-by: Michael J Gruber Signed-off-by: Junio C Hamano ---