From: Junio C Hamano Date: Tue, 16 Oct 2018 07:16:01 +0000 (+0900) Subject: Merge branch 'md/test-cleanup' X-Git-Tag: v2.20.0-rc0~183 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/f2e2136ad7291524a2b67a179dea493f4a562453?ds=inline;hp=-c Merge branch 'md/test-cleanup' Various test scripts have been updated for style and also correct handling of exit status of various commands. * md/test-cleanup: tests: order arguments to git-rev-list properly t9109: don't swallow Git errors upstream of pipes tests: don't swallow Git errors upstream of pipes t/*: fix ordering of expected/observed arguments tests: standardize pipe placement Documentation: add shell guidelines t/README: reformat Do, Don't, Keep in mind lists --- f2e2136ad7291524a2b67a179dea493f4a562453 diff --combined t/README index 5e48a043ce,3054e1534a..4d8dbc7c5f --- a/t/README +++ b/t/README @@@ -401,13 -401,13 +401,13 @@@ This test harness library does the foll consistently when command line arguments --verbose (or -v), --debug (or -d), and --immediate (or -i) is given. - Do's, don'ts & things to keep in mind - ------------------------------------- + Do's & don'ts + ------------- Here are a few examples of things you probably should and shouldn't do when writing tests. - Do: + Here are the "do's:" - Put all code inside test_expect_success and other assertions. @@@ -452,16 -452,21 +452,21 @@@ Windows, where the shell (MSYS bash) mangles absolute path names. For details, see the commit message of 4114156ae9. - Don't: + - Remember that inside the