From: Nguyễn Thái Ngọc Duy Date: Sat, 3 Nov 2018 08:48:49 +0000 (+0100) Subject: read-cache.c: initialize copy_len to shut up gcc 8 X-Git-Tag: v2.20.0-rc0~26^2~1 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/f5c4a9af45fa47130c730a5da87e030d040f000b?hp=--cc read-cache.c: initialize copy_len to shut up gcc 8 It was reported that when building with NO_PTHREADS=1, -Wmaybe-uninitialized is triggered. Just initialize the variable from the beginning to shut the compiler up (because this warning is enabled in config.dev) Signed-off-by: Nguyễn Thái Ngọc Duy Signed-off-by: Junio C Hamano --- f5c4a9af45fa47130c730a5da87e030d040f000b diff --git a/read-cache.c b/read-cache.c index 00cd416816..c510f598b1 100644 --- a/read-cache.c +++ b/read-cache.c @@ -1746,7 +1746,7 @@ static struct cache_entry *create_from_disk(struct mem_pool *ce_mem_pool, size_t len; const char *name; unsigned int flags; - size_t copy_len; + size_t copy_len = 0; /* * Adjacent cache entries tend to share the leading paths, so it makes * sense to only store the differences in later entries. In the v4 @@ -1786,8 +1786,6 @@ static struct cache_entry *create_from_disk(struct mem_pool *ce_mem_pool, die(_("malformed name field in the index, near path '%s'"), previous_ce->name); copy_len = previous_len - strip_len; - } else { - copy_len = 0; } name = (const char *)cp; }