From: Todd Zullinger <tmz@pobox.com>
Date: Sun, 8 Feb 2009 23:12:43 +0000 (-0500)
Subject: git-web--browse: Fix check for /bin/start
X-Git-Tag: v1.6.2-rc1~45
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/f6b98e46bdf64454d7c6ab76d617237118799d7b?hp=--cc

git-web--browse: Fix check for /bin/start

The previous check in git-web--browse for /bin/start used test -n
/bin/start, which was always true.  This lead to "start" being tried
first in the browser list.  On systems with upstart installed, "start"
exists and might be in the PATH, but it makes a poor choice for a web
browser.  Instead, test that /bin/start exists and is executable.

Signed-off-by: Todd Zullinger <tmz@pobox.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

f6b98e46bdf64454d7c6ab76d617237118799d7b
diff --git a/git-web--browse.sh b/git-web--browse.sh
index 78d236b77f..7ed0faddcd 100755
--- a/git-web--browse.sh
+++ b/git-web--browse.sh
@@ -115,7 +115,7 @@ if test -z "$browser" ; then
 	browser_candidates="open $browser_candidates"
     fi
     # /bin/start indicates MinGW
-    if test -n /bin/start; then
+    if test -x /bin/start; then
 	browser_candidates="start $browser_candidates"
     fi