From: Petr Baudis <pasky@suse.cz>
Date: Sat, 18 Nov 2006 02:56:52 +0000 (+0100)
Subject: Fix git-for-each-refs broken for tags
X-Git-Tag: v1.4.4.1~15
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/f8290630cb900fc5581e91a4cc055d2fba121db0

Fix git-for-each-refs broken for tags

Unfortunately, git-for-each-refs is currently unusable for peeking into tag
comments, since it uses freed pointers, so it just prints out all sort of
garbage.

This makes it strdup() contents and body values.

Signed-off-by: Petr Baudis <pasky@suse.cz>
Signed-off-by: Junio C Hamano <junkio@cox.net>
---

diff --git a/builtin-for-each-ref.c b/builtin-for-each-ref.c
index 173bf38735..227aa3cd7f 100644
--- a/builtin-for-each-ref.c
+++ b/builtin-for-each-ref.c
@@ -478,9 +478,9 @@ static void grab_sub_body_contents(struct atom_value *val, int deref, struct obj
 		if (!strcmp(name, "subject"))
 			v->s = copy_line(subpos);
 		else if (!strcmp(name, "body"))
-			v->s = bodypos;
+			v->s = xstrdup(bodypos);
 		else if (!strcmp(name, "contents"))
-			v->s = subpos;
+			v->s = xstrdup(subpos);
 	}
 }