From: David Kastrup <dak@gnu.org>
Date: Tue, 2 Apr 2019 11:56:25 +0000 (+0200)
Subject: blame.c: don't drop origin blobs as eagerly
X-Git-Tag: v2.22.0-rc0~57^2
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/f89201494308524a92eff5995d122e8553c36508?hp=--cc

blame.c: don't drop origin blobs as eagerly

When a parent blob already has chunks queued up for blaming, dropping
the blob at the end of one blame step will cause it to get reloaded
right away, doubling the amount of I/O and unpacking when processing a
linear history.

Keeping such parent blobs in memory seems like a reasonable optimization
that should incur additional memory pressure mostly when processing the
merges from old branches.

Signed-off-by: David Kastrup <dak@gnu.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

f89201494308524a92eff5995d122e8553c36508
diff --git a/blame.c b/blame.c
index da57233cbb..4e9ccd0922 100644
--- a/blame.c
+++ b/blame.c
@@ -1561,7 +1561,8 @@ static void pass_blame(struct blame_scoreboard *sb, struct blame_origin *origin,
 	}
 	for (i = 0; i < num_sg; i++) {
 		if (sg_origin[i]) {
-			drop_origin_blob(sg_origin[i]);
+			if (!sg_origin[i]->suspects)
+				drop_origin_blob(sg_origin[i]);
 			blame_origin_decref(sg_origin[i]);
 		}
 	}