From: Johannes Schindelin Date: Tue, 23 Dec 2014 13:25:05 +0000 (+0100) Subject: git remote: allow adding remotes agreeing with url.<...>.insteadOf X-Git-Tag: v2.3.0-rc1~22^2~1 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/fb86e32dcc9ed07ee2f1df6aafbf34d469007b1f?hp=fb86e32dcc9ed07ee2f1df6aafbf34d469007b1f git remote: allow adding remotes agreeing with url.<...>.insteadOf When adding a remote, we make sure that the remote does not exist already. However, this test was not quite correct: when the url.<...>.insteadOf config variable was set to the remote name to be added, the code would assume that the remote exists already. Let's allow adding remotes when there is a url.<...>.insteadOf setting when both the name and the URL agree with the remote to be added. It might seem like a mistake to compare against remote->url[0] without verifying that remote->url_nr >=1, but at this point a missing URL has been filled by the name already, therefore url_nr cannot be zero. Noticed by Anastas Dancha. Signed-off-by: Johannes Schindelin Signed-off-by: Junio C Hamano ---