From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mon, 2 Jul 2018 00:23:46 +0000 (-0400)
Subject: t5405: use test_must_fail() instead of checking exit code manually
X-Git-Tag: v2.19.0-rc0~109^2~20
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/fbd6ef273e1d1d88a4056b986bd8a331cc61ea39

t5405: use test_must_fail() instead of checking exit code manually

This test expects "git push" to fail, thus it manually inverts that
local expected failure into a successful exit code for the test overall.
In doing so, it intentionally breaks the &&-chain. Modernize by
replacing manual exit code management with test_must_fail() and a normal
&&-chain.

Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/t/t5405-send-pack-rewind.sh b/t/t5405-send-pack-rewind.sh
index 4bda18a662..235fb7686a 100755
--- a/t/t5405-send-pack-rewind.sh
+++ b/t/t5405-send-pack-rewind.sh
@@ -25,8 +25,7 @@ test_expect_success 'non forced push should die not segfault' '
 
 	(
 		cd another &&
-		git push .. master:master
-		test $? = 1
+		test_must_fail git push .. master:master
 	)
 
 '