From: Martin Ågren <martin.agren@gmail.com>
Date: Sun, 5 Nov 2017 20:24:29 +0000 (+0100)
Subject: bisect: fix memory leak in `find_bisection()`
X-Git-Tag: v2.15.1~4^2~2
X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/fc5c40bb2bb1921f3bdfa55c1d846dc080c356b2?hp=--cc

bisect: fix memory leak in `find_bisection()`

`find_bisection()` rebuilds the commit list it is given by reversing it
and skipping uninteresting commits. The uninteresting list entries are
leaked. Free them to fix the leak.

Signed-off-by: Martin Ågren <martin.agren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

fc5c40bb2bb1921f3bdfa55c1d846dc080c356b2
diff --git a/bisect.c b/bisect.c
index 5a3ae49714..2f4321767a 100644
--- a/bisect.c
+++ b/bisect.c
@@ -379,8 +379,10 @@ void find_bisection(struct commit_list **commit_list, int *reaches,
 		unsigned flags = p->item->object.flags;
 
 		next = p->next;
-		if (flags & UNINTERESTING)
+		if (flags & UNINTERESTING) {
+			free(p);
 			continue;
+		}
 		p->next = last;
 		last = p;
 		if (!(flags & TREESAME))