From: Chris Ridd Date: Wed, 11 Jun 2008 13:09:19 +0000 (+0100) Subject: Improve sed portability X-Git-Tag: v1.5.6-rc3~21 X-Git-Url: https://git.lorimer.id.au/gitweb.git/diff_plain/fe22e5420ee547bac58481ed1a868f4cd39ad128?hp=fe22e5420ee547bac58481ed1a868f4cd39ad128 Improve sed portability The behaviour of "sed" on an incomplete line is unspecified by POSIX, and On Solaris it apparently fails to process input that doesn't end in a LF. Consequently constructs like re=$(printf '%s' foo | sed -e 's/bar/BAR/g' $) cause re to be set to the empty string. Such a construct is used in git-submodule.sh. Because the LF at the end of command output are stripped away by the command substitution, it is a safe and sane change to add a LF at the end of the printf format specifier. Signed-off-by: Chris Ridd Signed-off-by: Junio C Hamano ---