From a48ebe9724b01e53f23e2a44a85f52237aaf5c34 Mon Sep 17 00:00:00 2001 From: Kaartic Sivaraam Date: Sat, 18 Nov 2017 22:56:47 +0530 Subject: [PATCH] branch: update warning message shown when copying a misnamed branch When a user tries to rename a branch that has a "bad name" (e.g., starts with a '-') then we warn them that the misnamed branch has been renamed "away". A similar message is shown when trying to create a copy of a misnamed branch even though it doesn't remove the misnamed branch. This is not correct and may confuse the user. So, update the warning message shown to be more precise that only a copy of the misnamed branch has been created. It's better to show the warning message than not showing it at all as it makes the user aware of the presence of a misnamed branch. Signed-off-by: Kaartic Sivaraam Signed-off-by: Junio C Hamano --- builtin/branch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/branch.c b/builtin/branch.c index 4edef5baa7..ca9d8abd09 100644 --- a/builtin/branch.c +++ b/builtin/branch.c @@ -507,7 +507,7 @@ static void copy_or_rename_branch(const char *oldname, const char *newname, int if (recovery) { if (copy) - warning(_("Copied a misnamed branch '%s' away"), + warning(_("Created a copy of a misnamed branch '%s'"), oldref.buf + 11); else warning(_("Renamed a misnamed branch '%s' away"), -- 2.43.2