From a92330d21c13cf244d8045f5c9d1df6e63893d58 Mon Sep 17 00:00:00 2001 From: Jeff King Date: Thu, 20 Aug 2015 10:49:45 -0400 Subject: [PATCH] get_urlmatch: avoid useless strbuf write We create a strbuf only to insert a single string, pass the resulting buffer to a function (which does not modify the string), and then free it. We can just pass the original string instead. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- builtin/config.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/builtin/config.c b/builtin/config.c index 04befce5b7..71acc44143 100644 --- a/builtin/config.c +++ b/builtin/config.c @@ -425,14 +425,11 @@ static int get_urlmatch(const char *var, const char *url) for_each_string_list_item(item, &values) { struct urlmatch_current_candidate_value *matched = item->util; - struct strbuf key = STRBUF_INIT; struct strbuf buf = STRBUF_INIT; - strbuf_addstr(&key, item->string); - format_config(&buf, key.buf, + format_config(&buf, item->string, matched->value_is_null ? NULL : matched->value.buf); fwrite(buf.buf, 1, buf.len, stdout); - strbuf_release(&key); strbuf_release(&buf); strbuf_release(&matched->value); -- 2.47.1