From edfb8ba06822375b08796b7b4354a94d98b05d13 Mon Sep 17 00:00:00 2001 From: Olga Telezhnaya Date: Wed, 21 Feb 2018 06:59:01 +0000 Subject: [PATCH] ref-filter: get rid of goto Get rid of goto command in ref-filter for better readability. Signed-off-by: Olga Telezhnaia Mentored-by: Christian Couder Mentored by: Jeff King Signed-off-by: Junio C Hamano --- ref-filter.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ref-filter.c b/ref-filter.c index 2570870439..be94766f78 100644 --- a/ref-filter.c +++ b/ref-filter.c @@ -1494,11 +1494,11 @@ static void populate_value(struct ref_array_item *ref) for (i = 0; i < used_atom_cnt; i++) { struct atom_value *v = &ref->value[i]; if (v->s == NULL) - goto need_obj; + break; } - return; + if (used_atom_cnt <= i) + return; - need_obj: get_object(ref, &ref->objectname, 0, &obj); /* -- 2.43.2