t / READMEon commit Merge branch 'jl/maint-pull-tags-doc' (03276d9)
   1Core GIT Tests
   2==============
   3
   4This directory holds many test scripts for core GIT tools.  The
   5first part of this short document describes how to run the tests
   6and read their output.
   7
   8When fixing the tools or adding enhancements, you are strongly
   9encouraged to add tests in this directory to cover what you are
  10trying to fix or enhance.  The later part of this short document
  11describes how your test scripts should be organized.
  12
  13
  14Running Tests
  15-------------
  16
  17The easiest way to run tests is to say "make".  This runs all
  18the tests.
  19
  20    *** t0000-basic.sh ***
  21    ok 1 - .git/objects should be empty after git init in an empty repo.
  22    ok 2 - .git/objects should have 3 subdirectories.
  23    ok 3 - success is reported like this
  24    ...
  25    ok 43 - very long name in the index handled sanely
  26    # fixed 1 known breakage(s)
  27    # still have 1 known breakage(s)
  28    # passed all remaining 42 test(s)
  29    1..43
  30    *** t0001-init.sh ***
  31    ok 1 - plain
  32    ok 2 - plain with GIT_WORK_TREE
  33    ok 3 - plain bare
  34
  35Since the tests all output TAP (see http://testanything.org) they can
  36be run with any TAP harness. Here's an example of parallel testing
  37powered by a recent version of prove(1):
  38
  39    $ prove --timer --jobs 15 ./t[0-9]*.sh
  40    [19:17:33] ./t0005-signals.sh ................................... ok       36 ms
  41    [19:17:33] ./t0022-crlf-rename.sh ............................... ok       69 ms
  42    [19:17:33] ./t0024-crlf-archive.sh .............................. ok      154 ms
  43    [19:17:33] ./t0004-unwritable.sh ................................ ok      289 ms
  44    [19:17:33] ./t0002-gitfile.sh ................................... ok      480 ms
  45    ===(     102;0  25/?  6/?  5/?  16/?  1/?  4/?  2/?  1/?  3/?  1... )===
  46
  47prove and other harnesses come with a lot of useful options. The
  48--state option in particular is very useful:
  49
  50    # Repeat until no more failures
  51    $ prove -j 15 --state=failed,save ./t[0-9]*.sh
  52
  53You can give DEFAULT_TEST_TARGET=prove on the make command (or define it
  54in config.mak) to cause "make test" to run tests under prove.
  55GIT_PROVE_OPTS can be used to pass additional options, e.g.
  56
  57    $ make DEFAULT_TEST_TARGET=prove GIT_PROVE_OPTS='--timer --jobs 16' test
  58
  59You can also run each test individually from command line, like this:
  60
  61    $ sh ./t3010-ls-files-killed-modified.sh
  62    ok 1 - git update-index --add to add various paths.
  63    ok 2 - git ls-files -k to show killed files.
  64    ok 3 - validate git ls-files -k output.
  65    ok 4 - git ls-files -m to show modified files.
  66    ok 5 - validate git ls-files -m output.
  67    # passed all 5 test(s)
  68    1..5
  69
  70You can pass --verbose (or -v), --debug (or -d), and --immediate
  71(or -i) command line argument to the test, or by setting GIT_TEST_OPTS
  72appropriately before running "make".
  73
  74--verbose::
  75        This makes the test more verbose.  Specifically, the
  76        command being run and their output if any are also
  77        output.
  78
  79--debug::
  80        This may help the person who is developing a new test.
  81        It causes the command defined with test_debug to run.
  82
  83--immediate::
  84        This causes the test to immediately exit upon the first
  85        failed test.
  86
  87--long-tests::
  88        This causes additional long-running tests to be run (where
  89        available), for more exhaustive testing.
  90
  91--valgrind::
  92        Execute all Git binaries with valgrind and exit with status
  93        126 on errors (just like regular tests, this will only stop
  94        the test script when running under -i).  Valgrind errors
  95        go to stderr, so you might want to pass the -v option, too.
  96
  97        Since it makes no sense to run the tests with --valgrind and
  98        not see any output, this option implies --verbose.  For
  99        convenience, it also implies --tee.
 100
 101--tee::
 102        In addition to printing the test output to the terminal,
 103        write it to files named 't/test-results/$TEST_NAME.out'.
 104        As the names depend on the tests' file names, it is safe to
 105        run the tests with this option in parallel.
 106
 107--with-dashes::
 108        By default tests are run without dashed forms of
 109        commands (like git-commit) in the PATH (it only uses
 110        wrappers from ../bin-wrappers).  Use this option to include
 111        the build directory (..) in the PATH, which contains all
 112        the dashed forms of commands.  This option is currently
 113        implied by other options like --valgrind and
 114        GIT_TEST_INSTALLED.
 115
 116--root=<directory>::
 117        Create "trash" directories used to store all temporary data during
 118        testing under <directory>, instead of the t/ directory.
 119        Using this option with a RAM-based filesystem (such as tmpfs)
 120        can massively speed up the test suite.
 121
 122You can also set the GIT_TEST_INSTALLED environment variable to
 123the bindir of an existing git installation to test that installation.
 124You still need to have built this git sandbox, from which various
 125test-* support programs, templates, and perl libraries are used.
 126If your installed git is incomplete, it will silently test parts of
 127your built version instead.
 128
 129When using GIT_TEST_INSTALLED, you can also set GIT_TEST_EXEC_PATH to
 130override the location of the dashed-form subcommands (what
 131GIT_EXEC_PATH would be used for during normal operation).
 132GIT_TEST_EXEC_PATH defaults to `$GIT_TEST_INSTALLED/git --exec-path`.
 133
 134
 135Skipping Tests
 136--------------
 137
 138In some environments, certain tests have no way of succeeding
 139due to platform limitation, such as lack of 'unzip' program, or
 140filesystem that do not allow arbitrary sequence of non-NUL bytes
 141as pathnames.
 142
 143You should be able to say something like
 144
 145    $ GIT_SKIP_TESTS=t9200.8 sh ./t9200-git-cvsexport-commit.sh
 146
 147and even:
 148
 149    $ GIT_SKIP_TESTS='t[0-4]??? t91?? t9200.8' make
 150
 151to omit such tests.  The value of the environment variable is a
 152SP separated list of patterns that tells which tests to skip,
 153and either can match the "t[0-9]{4}" part to skip the whole
 154test, or t[0-9]{4} followed by ".$number" to say which
 155particular test to skip.
 156
 157Note that some tests in the existing test suite rely on previous
 158test item, so you cannot arbitrarily disable one and expect the
 159remainder of test to check what the test originally was intended
 160to check.
 161
 162
 163Naming Tests
 164------------
 165
 166The test files are named as:
 167
 168        tNNNN-commandname-details.sh
 169
 170where N is a decimal digit.
 171
 172First digit tells the family:
 173
 174        0 - the absolute basics and global stuff
 175        1 - the basic commands concerning database
 176        2 - the basic commands concerning the working tree
 177        3 - the other basic commands (e.g. ls-files)
 178        4 - the diff commands
 179        5 - the pull and exporting commands
 180        6 - the revision tree commands (even e.g. merge-base)
 181        7 - the porcelainish commands concerning the working tree
 182        8 - the porcelainish commands concerning forensics
 183        9 - the git tools
 184
 185Second digit tells the particular command we are testing.
 186
 187Third digit (optionally) tells the particular switch or group of switches
 188we are testing.
 189
 190If you create files under t/ directory (i.e. here) that is not
 191the top-level test script, never name the file to match the above
 192pattern.  The Makefile here considers all such files as the
 193top-level test script and tries to run all of them.  A care is
 194especially needed if you are creating a common test library
 195file, similar to test-lib.sh, because such a library file may
 196not be suitable for standalone execution.
 197
 198
 199Writing Tests
 200-------------
 201
 202The test script is written as a shell script.  It should start
 203with the standard "#!/bin/sh" with copyright notices, and an
 204assignment to variable 'test_description', like this:
 205
 206        #!/bin/sh
 207        #
 208        # Copyright (c) 2005 Junio C Hamano
 209        #
 210
 211        test_description='xxx test (option --frotz)
 212
 213        This test registers the following structure in the cache
 214        and tries to run git-ls-files with option --frotz.'
 215
 216
 217Source 'test-lib.sh'
 218--------------------
 219
 220After assigning test_description, the test script should source
 221test-lib.sh like this:
 222
 223        . ./test-lib.sh
 224
 225This test harness library does the following things:
 226
 227 - If the script is invoked with command line argument --help
 228   (or -h), it shows the test_description and exits.
 229
 230 - Creates an empty test directory with an empty .git/objects database
 231   and chdir(2) into it.  This directory is 't/trash
 232   directory.$test_name_without_dotsh', with t/ subject to change by
 233   the --root option documented above.
 234
 235 - Defines standard test helper functions for your scripts to
 236   use.  These functions are designed to make all scripts behave
 237   consistently when command line arguments --verbose (or -v),
 238   --debug (or -d), and --immediate (or -i) is given.
 239
 240Do's, don'ts & things to keep in mind
 241-------------------------------------
 242
 243Here are a few examples of things you probably should and shouldn't do
 244when writing tests.
 245
 246Do:
 247
 248 - Put all code inside test_expect_success and other assertions.
 249
 250   Even code that isn't a test per se, but merely some setup code
 251   should be inside a test assertion.
 252
 253 - Chain your test assertions
 254
 255   Write test code like this:
 256
 257        git merge foo &&
 258        git push bar &&
 259        test ...
 260
 261   Instead of:
 262
 263        git merge hla
 264        git push gh
 265        test ...
 266
 267   That way all of the commands in your tests will succeed or fail. If
 268   you must ignore the return value of something (e.g., the return
 269   after unsetting a variable that was already unset is unportable) it's
 270   best to indicate so explicitly with a semicolon:
 271
 272        unset HLAGH;
 273        git merge hla &&
 274        git push gh &&
 275        test ...
 276
 277 - Check the test coverage for your tests. See the "Test coverage"
 278   below.
 279
 280   Don't blindly follow test coverage metrics, they're a good way to
 281   spot if you've missed something. If a new function you added
 282   doesn't have any coverage you're probably doing something wrong,
 283   but having 100% coverage doesn't necessarily mean that you tested
 284   everything.
 285
 286   Tests that are likely to smoke out future regressions are better
 287   than tests that just inflate the coverage metrics.
 288
 289Don't:
 290
 291 - exit() within a <script> part.
 292
 293   The harness will catch this as a programming error of the test.
 294   Use test_done instead if you need to stop the tests early (see
 295   "Skipping tests" below).
 296
 297 - Break the TAP output
 298
 299   The raw output from your test may be interpreted by a TAP harness. TAP
 300   harnesses will ignore everything they don't know about, but don't step
 301   on their toes in these areas:
 302
 303   - Don't print lines like "$x..$y" where $x and $y are integers.
 304
 305   - Don't print lines that begin with "ok" or "not ok".
 306
 307   TAP harnesses expect a line that begins with either "ok" and "not
 308   ok" to signal a test passed or failed (and our harness already
 309   produces such lines), so your script shouldn't emit such lines to
 310   their output.
 311
 312   You can glean some further possible issues from the TAP grammar
 313   (see http://search.cpan.org/perldoc?TAP::Parser::Grammar#TAP_Grammar)
 314   but the best indication is to just run the tests with prove(1),
 315   it'll complain if anything is amiss.
 316
 317Keep in mind:
 318
 319 - Inside <script> part, the standard output and standard error
 320   streams are discarded, and the test harness only reports "ok" or
 321   "not ok" to the end user running the tests. Under --verbose, they
 322   are shown to help debugging the tests.
 323
 324
 325Skipping tests
 326--------------
 327
 328If you need to skip tests you should do so be using the three-arg form
 329of the test_* functions (see the "Test harness library" section
 330below), e.g.:
 331
 332    test_expect_success PERL 'I need Perl' "
 333        '$PERL_PATH' -e 'hlagh() if unf_unf()'
 334    "
 335
 336The advantage of skipping tests like this is that platforms that don't
 337have the PERL and other optional dependencies get an indication of how
 338many tests they're missing.
 339
 340If the test code is too hairy for that (i.e. does a lot of setup work
 341outside test assertions) you can also skip all remaining tests by
 342setting skip_all and immediately call test_done:
 343
 344        if ! test_have_prereq PERL
 345        then
 346            skip_all='skipping perl interface tests, perl not available'
 347            test_done
 348        fi
 349
 350The string you give to skip_all will be used as an explanation for why
 351the test was skipped.
 352
 353End with test_done
 354------------------
 355
 356Your script will be a sequence of tests, using helper functions
 357from the test harness library.  At the end of the script, call
 358'test_done'.
 359
 360
 361Test harness library
 362--------------------
 363
 364There are a handful helper functions defined in the test harness
 365library for your script to use.
 366
 367 - test_expect_success [<prereq>] <message> <script>
 368
 369   Usually takes two strings as parameter, and evaluates the
 370   <script>.  If it yields success, test is considered
 371   successful.  <message> should state what it is testing.
 372
 373   Example:
 374
 375        test_expect_success \
 376            'git-write-tree should be able to write an empty tree.' \
 377            'tree=$(git-write-tree)'
 378
 379   If you supply three parameters the first will be taken to be a
 380   prerequisite, see the test_set_prereq and test_have_prereq
 381   documentation below:
 382
 383        test_expect_success TTY 'git --paginate rev-list uses a pager' \
 384            ' ... '
 385
 386   You can also supply a comma-separated list of prerequisites, in the
 387   rare case where your test depends on more than one:
 388
 389        test_expect_success PERL,PYTHON 'yo dawg' \
 390            ' test $(perl -E 'print eval "1 +" . qx[python -c "print 2"]') == "4" '
 391
 392 - test_expect_failure [<prereq>] <message> <script>
 393
 394   This is NOT the opposite of test_expect_success, but is used
 395   to mark a test that demonstrates a known breakage.  Unlike
 396   the usual test_expect_success tests, which say "ok" on
 397   success and "FAIL" on failure, this will say "FIXED" on
 398   success and "still broken" on failure.  Failures from these
 399   tests won't cause -i (immediate) to stop.
 400
 401   Like test_expect_success this function can optionally use a three
 402   argument invocation with a prerequisite as the first argument.
 403
 404 - test_expect_code [<prereq>] <code> <message> <script>
 405
 406   Analogous to test_expect_success, but pass the test if it exits
 407   with a given exit <code>
 408
 409 test_expect_code 1 'Merge with d/f conflicts' 'git merge "merge msg" B master'
 410
 411 - test_debug <script>
 412
 413   This takes a single argument, <script>, and evaluates it only
 414   when the test script is started with --debug command line
 415   argument.  This is primarily meant for use during the
 416   development of a new test script.
 417
 418 - test_done
 419
 420   Your test script must have test_done at the end.  Its purpose
 421   is to summarize successes and failures in the test script and
 422   exit with an appropriate error code.
 423
 424 - test_tick
 425
 426   Make commit and tag names consistent by setting the author and
 427   committer times to defined stated.  Subsequent calls will
 428   advance the times by a fixed amount.
 429
 430 - test_commit <message> [<filename> [<contents>]]
 431
 432   Creates a commit with the given message, committing the given
 433   file with the given contents (default for both is to reuse the
 434   message string), and adds a tag (again reusing the message
 435   string as name).  Calls test_tick to make the SHA-1s
 436   reproducible.
 437
 438 - test_merge <message> <commit-or-tag>
 439
 440   Merges the given rev using the given message.  Like test_commit,
 441   creates a tag and calls test_tick before committing.
 442
 443 - test_set_prereq SOME_PREREQ
 444
 445   Set a test prerequisite to be used later with test_have_prereq. The
 446   test-lib will set some prerequisites for you, see the
 447   "Prerequisites" section below for a full list of these.
 448
 449   Others you can set yourself and use later with either
 450   test_have_prereq directly, or the three argument invocation of
 451   test_expect_success and test_expect_failure.
 452
 453 - test_have_prereq SOME PREREQ
 454
 455   Check if we have a prerequisite previously set with
 456   test_set_prereq. The most common use of this directly is to skip
 457   all the tests if we don't have some essential prerequisite:
 458
 459        if ! test_have_prereq PERL
 460        then
 461            skip_all='skipping perl interface tests, perl not available'
 462            test_done
 463        fi
 464
 465 - test_external [<prereq>] <message> <external> <script>
 466
 467   Execute a <script> with an <external> interpreter (like perl). This
 468   was added for tests like t9700-perl-git.sh which do most of their
 469   work in an external test script.
 470
 471        test_external \
 472            'GitwebCache::*FileCache*' \
 473            "$PERL_PATH" "$TEST_DIRECTORY"/t9503/test_cache_interface.pl
 474
 475   If the test is outputting its own TAP you should set the
 476   test_external_has_tap variable somewhere before calling the first
 477   test_external* function. See t9700-perl-git.sh for an example.
 478
 479        # The external test will outputs its own plan
 480        test_external_has_tap=1
 481
 482 - test_external_without_stderr [<prereq>] <message> <external> <script>
 483
 484   Like test_external but fail if there's any output on stderr,
 485   instead of checking the exit code.
 486
 487        test_external_without_stderr \
 488            'Perl API' \
 489            "$PERL_PATH" "$TEST_DIRECTORY"/t9700/test.pl
 490
 491 - test_must_fail <git-command>
 492
 493   Run a git command and ensure it fails in a controlled way.  Use
 494   this instead of "! <git-command>".  When git-command dies due to a
 495   segfault, test_must_fail diagnoses it as an error; "! <git-command>"
 496   treats it as just another expected failure, which would let such a
 497   bug go unnoticed.
 498
 499 - test_might_fail <git-command>
 500
 501   Similar to test_must_fail, but tolerate success, too.  Use this
 502   instead of "<git-command> || :" to catch failures due to segv.
 503
 504 - test_cmp <expected> <actual>
 505
 506   Check whether the content of the <actual> file matches the
 507   <expected> file.  This behaves like "cmp" but produces more
 508   helpful output when the test is run with "-v" option.
 509
 510 - test_path_is_file <file> [<diagnosis>]
 511   test_path_is_dir <dir> [<diagnosis>]
 512   test_path_is_missing <path> [<diagnosis>]
 513
 514   Check whether a file/directory exists or doesn't. <diagnosis> will
 515   be displayed if the test fails.
 516
 517 - test_when_finished <script>
 518
 519   Prepend <script> to a list of commands to run to clean up
 520   at the end of the current test.  If some clean-up command
 521   fails, the test will not pass.
 522
 523   Example:
 524
 525        test_expect_success 'branch pointing to non-commit' '
 526                git rev-parse HEAD^{tree} >.git/refs/heads/invalid &&
 527                test_when_finished "git update-ref -d refs/heads/invalid" &&
 528                ...
 529        '
 530
 531Prerequisites
 532-------------
 533
 534These are the prerequisites that the test library predefines with
 535test_have_prereq.
 536
 537See the prereq argument to the test_* functions in the "Test harness
 538library" section above and the "test_have_prereq" function for how to
 539use these, and "test_set_prereq" for how to define your own.
 540
 541 - PERL & PYTHON
 542
 543   Git wasn't compiled with NO_PERL=YesPlease or
 544   NO_PYTHON=YesPlease. Wrap any tests that need Perl or Python in
 545   these.
 546
 547 - POSIXPERM
 548
 549   The filesystem supports POSIX style permission bits.
 550
 551 - BSLASHPSPEC
 552
 553   Backslashes in pathspec are not directory separators. This is not
 554   set on Windows. See 6fd1106a for details.
 555
 556 - EXECKEEPSPID
 557
 558   The process retains the same pid across exec(2). See fb9a2bea for
 559   details.
 560
 561 - SYMLINKS
 562
 563   The filesystem we're on supports symbolic links. E.g. a FAT
 564   filesystem doesn't support these. See 704a3143 for details.
 565
 566 - SANITY
 567
 568   Test is not run by root user, and an attempt to write to an
 569   unwritable file is expected to fail correctly.
 570
 571Tips for Writing Tests
 572----------------------
 573
 574As with any programming projects, existing programs are the best
 575source of the information.  However, do _not_ emulate
 576t0000-basic.sh when writing your tests.  The test is special in
 577that it tries to validate the very core of GIT.  For example, it
 578knows that there will be 256 subdirectories under .git/objects/,
 579and it knows that the object ID of an empty tree is a certain
 58040-byte string.  This is deliberately done so in t0000-basic.sh
 581because the things the very basic core test tries to achieve is
 582to serve as a basis for people who are changing the GIT internal
 583drastically.  For these people, after making certain changes,
 584not seeing failures from the basic test _is_ a failure.  And
 585such drastic changes to the core GIT that even changes these
 586otherwise supposedly stable object IDs should be accompanied by
 587an update to t0000-basic.sh.
 588
 589However, other tests that simply rely on basic parts of the core
 590GIT working properly should not have that level of intimate
 591knowledge of the core GIT internals.  If all the test scripts
 592hardcoded the object IDs like t0000-basic.sh does, that defeats
 593the purpose of t0000-basic.sh, which is to isolate that level of
 594validation in one place.  Your test also ends up needing
 595updating when such a change to the internal happens, so do _not_
 596do it and leave the low level of validation to t0000-basic.sh.
 597
 598Test coverage
 599-------------
 600
 601You can use the coverage tests to find code paths that are not being
 602used or properly exercised yet.
 603
 604To do that, run the coverage target at the top-level (not in the t/
 605directory):
 606
 607    make coverage
 608
 609That'll compile Git with GCC's coverage arguments, and generate a test
 610report with gcov after the tests finish. Running the coverage tests
 611can take a while, since running the tests in parallel is incompatible
 612with GCC's coverage mode.
 613
 614After the tests have run you can generate a list of untested
 615functions:
 616
 617    make coverage-untested-functions
 618
 619You can also generate a detailed per-file HTML report using the
 620Devel::Cover module. To install it do:
 621
 622   # On Debian or Ubuntu:
 623   sudo aptitude install libdevel-cover-perl
 624
 625   # From the CPAN with cpanminus
 626   curl -L http://cpanmin.us | perl - --sudo --self-upgrade
 627   cpanm --sudo Devel::Cover
 628
 629Then, at the top-level:
 630
 631    make cover_db_html
 632
 633That'll generate a detailed cover report in the "cover_db_html"
 634directory, which you can then copy to a webserver, or inspect locally
 635in a browser.
 636
 637Smoke testing
 638-------------
 639
 640The Git test suite has support for smoke testing. Smoke testing is
 641when you submit the results of a test run to a central server for
 642analysis and aggregation.
 643
 644Running a smoke tester is an easy and valuable way of contributing to
 645Git development, particularly if you have access to an uncommon OS on
 646obscure hardware.
 647
 648After building Git you can generate a smoke report like this in the
 649"t" directory:
 650
 651    make clean smoke
 652
 653You can also pass arguments via the environment. This should make it
 654faster:
 655
 656    GIT_TEST_OPTS='--root=/dev/shm' TEST_JOBS=10 make clean smoke
 657
 658The "smoke" target will run the Git test suite with Perl's
 659"TAP::Harness" module, and package up the results in a .tar.gz archive
 660with "TAP::Harness::Archive". The former is included with Perl v5.10.1
 661or later, but you'll need to install the latter from the CPAN. See the
 662"Test coverage" section above for how you might do that.
 663
 664Once the "smoke" target finishes you'll see a message like this:
 665
 666    TAP Archive created at <path to git>/t/test-results/git-smoke.tar.gz
 667
 668To upload the smoke report you need to have curl(1) installed, then
 669do:
 670
 671    make smoke_report
 672
 673To upload the report anonymously. Hopefully that'll return something
 674like "Reported #7 added.".
 675
 676If you're going to be uploading reports frequently please request a
 677user account by E-Mailing gitsmoke@v.nix.is. Once you have a username
 678and password you'll be able to do:
 679
 680    SMOKE_USERNAME=<username> SMOKE_PASSWORD=<password> make smoke_report
 681
 682You can also add an additional comment to attach to the report, and/or
 683a comma separated list of tags:
 684
 685    SMOKE_USERNAME=<username> SMOKE_PASSWORD=<password> \
 686        SMOKE_COMMENT=<comment> SMOKE_TAGS=<tags> \
 687        make smoke_report
 688
 689Once the report is uploaded it'll be made available at
 690http://smoke.git.nix.is, here's an overview of Recent Smoke Reports
 691for Git:
 692
 693    http://smoke.git.nix.is/app/projects/smoke_reports/1
 694
 695The reports will also be mirrored to GitHub every few hours:
 696
 697    http://github.com/gitsmoke/smoke-reports
 698
 699The Smolder SQLite database is also mirrored and made available for
 700download:
 701
 702    http://github.com/gitsmoke/smoke-database
 703
 704Note that the database includes hashed (with crypt()) user passwords
 705and E-Mail addresses. Don't use a valuable password for the smoke
 706service if you have an account, or an E-Mail address you don't want to
 707be publicly known. The user accounts are just meant to be convenient
 708labels, they're not meant to be secure.