t / t7502-commit.shon commit t7502: narrow checks for author/committer name in template (1f4bf34)
   1#!/bin/sh
   2
   3test_description='git commit porcelain-ish'
   4
   5. ./test-lib.sh
   6
   7# Arguments: [<prefix] [<commit message>] [<commit options>]
   8check_summary_oneline() {
   9        test_tick &&
  10        git commit ${3+"$3"} -m "$2" | head -1 > act &&
  11
  12        # branch name
  13        SUMMARY_PREFIX="$(git name-rev --name-only HEAD)" &&
  14
  15        # append the "special" prefix, like "root-commit", "detached HEAD"
  16        if test -n "$1"
  17        then
  18                SUMMARY_PREFIX="$SUMMARY_PREFIX ($1)"
  19        fi
  20
  21        # abbrev SHA-1
  22        SUMMARY_POSTFIX="$(git log -1 --pretty='format:%h')"
  23        echo "[$SUMMARY_PREFIX $SUMMARY_POSTFIX] $2" >exp &&
  24
  25        test_i18ncmp exp act
  26}
  27
  28test_expect_success 'output summary format' '
  29
  30        echo new >file1 &&
  31        git add file1 &&
  32        check_summary_oneline "root-commit" "initial" &&
  33
  34        echo change >>file1 &&
  35        git add file1
  36'
  37
  38test_expect_success 'output summary format: root-commit' '
  39        check_summary_oneline "" "a change"
  40'
  41
  42test_expect_success 'output summary format for commit with an empty diff' '
  43
  44        check_summary_oneline "" "empty" "--allow-empty"
  45'
  46
  47test_expect_success 'output summary format for merges' '
  48
  49        git checkout -b recursive-base &&
  50        test_commit base file1 &&
  51
  52        git checkout -b recursive-a recursive-base &&
  53        test_commit commit-a file1 &&
  54
  55        git checkout -b recursive-b recursive-base &&
  56        test_commit commit-b file1 &&
  57
  58        # conflict
  59        git checkout recursive-a &&
  60        test_must_fail git merge recursive-b &&
  61        # resolve the conflict
  62        echo commit-a > file1 &&
  63        git add file1 &&
  64        check_summary_oneline "" "Merge"
  65'
  66
  67output_tests_cleanup() {
  68        # this is needed for "do not fire editor in the presence of conflicts"
  69        git checkout master &&
  70
  71        # this is needed for the "partial removal" test to pass
  72        git rm file1 &&
  73        git commit -m "cleanup"
  74}
  75
  76test_expect_success 'the basics' '
  77
  78        output_tests_cleanup &&
  79
  80        echo doing partial >"commit is" &&
  81        mkdir not &&
  82        echo very much encouraged but we should >not/forbid &&
  83        git add "commit is" not &&
  84        echo update added "commit is" file >"commit is" &&
  85        echo also update another >not/forbid &&
  86        test_tick &&
  87        git commit -a -m "initial with -a" &&
  88
  89        git cat-file blob HEAD:"commit is" >current.1 &&
  90        git cat-file blob HEAD:not/forbid >current.2 &&
  91
  92        cmp current.1 "commit is" &&
  93        cmp current.2 not/forbid
  94
  95'
  96
  97test_expect_success 'partial' '
  98
  99        echo another >"commit is" &&
 100        echo another >not/forbid &&
 101        test_tick &&
 102        git commit -m "partial commit to handle a file" "commit is" &&
 103
 104        changed=$(git diff-tree --name-only HEAD^ HEAD) &&
 105        test "$changed" = "commit is"
 106
 107'
 108
 109test_expect_success 'partial modification in a subdirectory' '
 110
 111        test_tick &&
 112        git commit -m "partial commit to subdirectory" not &&
 113
 114        changed=$(git diff-tree -r --name-only HEAD^ HEAD) &&
 115        test "$changed" = "not/forbid"
 116
 117'
 118
 119test_expect_success 'partial removal' '
 120
 121        git rm not/forbid &&
 122        git commit -m "partial commit to remove not/forbid" not &&
 123
 124        changed=$(git diff-tree -r --name-only HEAD^ HEAD) &&
 125        test "$changed" = "not/forbid" &&
 126        remain=$(git ls-tree -r --name-only HEAD) &&
 127        test "$remain" = "commit is"
 128
 129'
 130
 131test_expect_success 'sign off' '
 132
 133        >positive &&
 134        git add positive &&
 135        git commit -s -m "thank you" &&
 136        actual=$(git cat-file commit HEAD | sed -ne "s/Signed-off-by: //p") &&
 137        expected=$(git var GIT_COMMITTER_IDENT | sed -e "s/>.*/>/") &&
 138        test "z$actual" = "z$expected"
 139
 140'
 141
 142test_expect_success 'multiple -m' '
 143
 144        >negative &&
 145        git add negative &&
 146        git commit -m "one" -m "two" -m "three" &&
 147        actual=$(git cat-file commit HEAD | sed -e "1,/^\$/d") &&
 148        expected=$(echo one; echo; echo two; echo; echo three) &&
 149        test "z$actual" = "z$expected"
 150
 151'
 152
 153test_expect_success 'verbose' '
 154
 155        echo minus >negative &&
 156        git add negative &&
 157        git status -v | sed -ne "/^diff --git /p" >actual &&
 158        echo "diff --git a/negative b/negative" >expect &&
 159        test_cmp expect actual
 160
 161'
 162
 163test_expect_success 'verbose respects diff config' '
 164
 165        git config color.diff always &&
 166        git status -v >actual &&
 167        grep "\[1mdiff --git" actual &&
 168        git config --unset color.diff
 169'
 170
 171test_expect_success 'cleanup commit messages (verbatim,-t)' '
 172
 173        echo >>negative &&
 174        { echo;echo "# text";echo; } >expect &&
 175        git commit --cleanup=verbatim -t expect -a &&
 176        git cat-file -p HEAD |sed -e "1,/^\$/d" |head -n 3 >actual &&
 177        test_cmp expect actual
 178
 179'
 180
 181test_expect_success 'cleanup commit messages (verbatim,-F)' '
 182
 183        echo >>negative &&
 184        git commit --cleanup=verbatim -F expect -a &&
 185        git cat-file -p HEAD |sed -e "1,/^\$/d">actual &&
 186        test_cmp expect actual
 187
 188'
 189
 190test_expect_success 'cleanup commit messages (verbatim,-m)' '
 191
 192        echo >>negative &&
 193        git commit --cleanup=verbatim -m "$(cat expect)" -a &&
 194        git cat-file -p HEAD |sed -e "1,/^\$/d">actual &&
 195        test_cmp expect actual
 196
 197'
 198
 199test_expect_success 'cleanup commit messages (whitespace,-F)' '
 200
 201        echo >>negative &&
 202        { echo;echo "# text";echo; } >text &&
 203        echo "# text" >expect &&
 204        git commit --cleanup=whitespace -F text -a &&
 205        git cat-file -p HEAD |sed -e "1,/^\$/d">actual &&
 206        test_cmp expect actual
 207
 208'
 209
 210test_expect_success 'cleanup commit messages (strip,-F)' '
 211
 212        echo >>negative &&
 213        { echo;echo "# text";echo sample;echo; } >text &&
 214        echo sample >expect &&
 215        git commit --cleanup=strip -F text -a &&
 216        git cat-file -p HEAD |sed -e "1,/^\$/d">actual &&
 217        test_cmp expect actual
 218
 219'
 220
 221test_expect_success 'cleanup commit messages (strip,-F,-e)' '
 222
 223        echo >>negative &&
 224        { echo;echo sample;echo; } >text &&
 225        git commit -e -F text -a &&
 226        head -n 4 .git/COMMIT_EDITMSG >actual
 227'
 228
 229echo "sample
 230
 231# Please enter the commit message for your changes. Lines starting
 232# with '#' will be ignored, and an empty message aborts the commit." >expect
 233
 234test_expect_success 'cleanup commit messages (strip,-F,-e): output' '
 235        test_i18ncmp expect actual
 236'
 237
 238test_expect_success 'message shows author when it is not equal to committer' '
 239        echo >>negative &&
 240        test_might_fail git commit -e -m "sample" &&
 241        test_i18ngrep \
 242          "^# Author: *A U Thor <author@example.com>\$" \
 243          .git/COMMIT_EDITMSG
 244'
 245
 246test_expect_success 'message shows committer when it is automatic' '
 247
 248        echo >>negative &&
 249        (
 250                sane_unset GIT_COMMITTER_EMAIL &&
 251                sane_unset GIT_COMMITTER_NAME &&
 252                # must fail because there is no change
 253                test_must_fail git commit -e -m "sample"
 254        ) &&
 255        # the ident is calculated from the system, so we cannot
 256        # check the actual value, only that it is there
 257        test_i18ngrep "^# Committer: " .git/COMMIT_EDITMSG
 258'
 259
 260write_script .git/FAKE_EDITOR <<EOF
 261echo editor started > "$(pwd)/.git/result"
 262exit 0
 263EOF
 264
 265test_expect_success 'do not fire editor in the presence of conflicts' '
 266
 267        git clean -f &&
 268        echo f >g &&
 269        git add g &&
 270        git commit -m "add g" &&
 271        git branch second &&
 272        echo master >g &&
 273        echo g >h &&
 274        git add g h &&
 275        git commit -m "modify g and add h" &&
 276        git checkout second &&
 277        echo second >g &&
 278        git add g &&
 279        git commit -m second &&
 280        # Must fail due to conflict
 281        test_must_fail git cherry-pick -n master &&
 282        echo "editor not started" >.git/result &&
 283        (
 284                GIT_EDITOR="\"$(pwd)/.git/FAKE_EDITOR\"" &&
 285                export GIT_EDITOR &&
 286                test_must_fail git commit
 287        ) &&
 288        test "$(cat .git/result)" = "editor not started"
 289'
 290
 291write_script .git/FAKE_EDITOR <<EOF
 292# kill -TERM command added below.
 293EOF
 294
 295test_expect_success EXECKEEPSPID 'a SIGTERM should break locks' '
 296        echo >>negative &&
 297        ! "$SHELL_PATH" -c '\''
 298          echo kill -TERM $$ >> .git/FAKE_EDITOR
 299          GIT_EDITOR=.git/FAKE_EDITOR
 300          export GIT_EDITOR
 301          exec git commit -a'\'' &&
 302        test ! -f .git/index.lock
 303'
 304
 305rm -f .git/MERGE_MSG .git/COMMIT_EDITMSG
 306git reset -q --hard
 307
 308test_expect_success 'Hand committing of a redundant merge removes dups' '
 309
 310        git rev-parse second master >expect &&
 311        test_must_fail git merge second master &&
 312        git checkout master g &&
 313        EDITOR=: git commit -a &&
 314        git cat-file commit HEAD | sed -n -e "s/^parent //p" -e "/^$/q" >actual &&
 315        test_cmp expect actual
 316
 317'
 318
 319test_expect_success 'A single-liner subject with a token plus colon is not a footer' '
 320
 321        git reset --hard &&
 322        git commit -s -m "hello: kitty" --allow-empty &&
 323        git cat-file commit HEAD | sed -e "1,/^$/d" >actual &&
 324        test_line_count = 3 actual
 325
 326'
 327
 328write_script .git/FAKE_EDITOR <<\EOF
 329mv "$1" "$1.orig"
 330(
 331        echo message
 332        cat "$1.orig"
 333) >"$1"
 334EOF
 335
 336echo '## Custom template' >template
 337
 338clear_config () {
 339        (
 340                git config --unset-all "$1"
 341                case $? in
 342                0|5)    exit 0 ;;
 343                *)      exit 1 ;;
 344                esac
 345        )
 346}
 347
 348try_commit () {
 349        git reset --hard &&
 350        echo >>negative &&
 351        GIT_EDITOR=.git/FAKE_EDITOR git commit -a $* $use_template &&
 352        case "$use_template" in
 353        '')
 354                test_i18ngrep ! "^## Custom template" .git/COMMIT_EDITMSG ;;
 355        *)
 356                test_i18ngrep "^## Custom template" .git/COMMIT_EDITMSG ;;
 357        esac
 358}
 359
 360try_commit_status_combo () {
 361
 362        test_expect_success 'commit' '
 363                clear_config commit.status &&
 364                try_commit "" &&
 365                test_i18ngrep "^# Changes to be committed:" .git/COMMIT_EDITMSG
 366        '
 367
 368        test_expect_success 'commit' '
 369                clear_config commit.status &&
 370                try_commit "" &&
 371                test_i18ngrep "^# Changes to be committed:" .git/COMMIT_EDITMSG
 372        '
 373
 374        test_expect_success 'commit --status' '
 375                clear_config commit.status &&
 376                try_commit --status &&
 377                test_i18ngrep "^# Changes to be committed:" .git/COMMIT_EDITMSG
 378        '
 379
 380        test_expect_success 'commit --no-status' '
 381                clear_config commit.status &&
 382                try_commit --no-status &&
 383                test_i18ngrep ! "^# Changes to be committed:" .git/COMMIT_EDITMSG
 384        '
 385
 386        test_expect_success 'commit with commit.status = yes' '
 387                clear_config commit.status &&
 388                git config commit.status yes &&
 389                try_commit "" &&
 390                test_i18ngrep "^# Changes to be committed:" .git/COMMIT_EDITMSG
 391        '
 392
 393        test_expect_success 'commit with commit.status = no' '
 394                clear_config commit.status &&
 395                git config commit.status no &&
 396                try_commit "" &&
 397                test_i18ngrep ! "^# Changes to be committed:" .git/COMMIT_EDITMSG
 398        '
 399
 400        test_expect_success 'commit --status with commit.status = yes' '
 401                clear_config commit.status &&
 402                git config commit.status yes &&
 403                try_commit --status &&
 404                test_i18ngrep "^# Changes to be committed:" .git/COMMIT_EDITMSG
 405        '
 406
 407        test_expect_success 'commit --no-status with commit.status = yes' '
 408                clear_config commit.status &&
 409                git config commit.status yes &&
 410                try_commit --no-status &&
 411                test_i18ngrep ! "^# Changes to be committed:" .git/COMMIT_EDITMSG
 412        '
 413
 414        test_expect_success 'commit --status with commit.status = no' '
 415                clear_config commit.status &&
 416                git config commit.status no &&
 417                try_commit --status &&
 418                test_i18ngrep "^# Changes to be committed:" .git/COMMIT_EDITMSG
 419        '
 420
 421        test_expect_success 'commit --no-status with commit.status = no' '
 422                clear_config commit.status &&
 423                git config commit.status no &&
 424                try_commit --no-status &&
 425                test_i18ngrep ! "^# Changes to be committed:" .git/COMMIT_EDITMSG
 426        '
 427
 428}
 429
 430try_commit_status_combo
 431
 432use_template="-t template"
 433
 434try_commit_status_combo
 435
 436test_done