list-objects.con commit list-objects.c: handle unexpected non-blob entries (23c2044)
   1#include "cache.h"
   2#include "tag.h"
   3#include "commit.h"
   4#include "tree.h"
   5#include "blob.h"
   6#include "diff.h"
   7#include "tree-walk.h"
   8#include "revision.h"
   9#include "list-objects.h"
  10#include "list-objects-filter.h"
  11#include "list-objects-filter-options.h"
  12#include "packfile.h"
  13#include "object-store.h"
  14#include "trace.h"
  15
  16struct traversal_context {
  17        struct rev_info *revs;
  18        show_object_fn show_object;
  19        show_commit_fn show_commit;
  20        void *show_data;
  21        filter_object_fn filter_fn;
  22        void *filter_data;
  23};
  24
  25static void process_blob(struct traversal_context *ctx,
  26                         struct blob *blob,
  27                         struct strbuf *path,
  28                         const char *name)
  29{
  30        struct object *obj = &blob->object;
  31        size_t pathlen;
  32        enum list_objects_filter_result r = LOFR_MARK_SEEN | LOFR_DO_SHOW;
  33
  34        if (!ctx->revs->blob_objects)
  35                return;
  36        if (!obj)
  37                die("bad blob object");
  38        if (obj->flags & (UNINTERESTING | SEEN))
  39                return;
  40
  41        /*
  42         * Pre-filter known-missing objects when explicitly requested.
  43         * Otherwise, a missing object error message may be reported
  44         * later (depending on other filtering criteria).
  45         *
  46         * Note that this "--exclude-promisor-objects" pre-filtering
  47         * may cause the actual filter to report an incomplete list
  48         * of missing objects.
  49         */
  50        if (ctx->revs->exclude_promisor_objects &&
  51            !has_object_file(&obj->oid) &&
  52            is_promisor_object(&obj->oid))
  53                return;
  54
  55        pathlen = path->len;
  56        strbuf_addstr(path, name);
  57        if ((obj->flags & NOT_USER_GIVEN) && ctx->filter_fn)
  58                r = ctx->filter_fn(ctx->revs->repo,
  59                                   LOFS_BLOB, obj,
  60                                   path->buf, &path->buf[pathlen],
  61                                   ctx->filter_data);
  62        if (r & LOFR_MARK_SEEN)
  63                obj->flags |= SEEN;
  64        if (r & LOFR_DO_SHOW)
  65                ctx->show_object(obj, path->buf, ctx->show_data);
  66        strbuf_setlen(path, pathlen);
  67}
  68
  69/*
  70 * Processing a gitlink entry currently does nothing, since
  71 * we do not recurse into the subproject.
  72 *
  73 * We *could* eventually add a flag that actually does that,
  74 * which would involve:
  75 *  - is the subproject actually checked out?
  76 *  - if so, see if the subproject has already been added
  77 *    to the alternates list, and add it if not.
  78 *  - process the commit (or tag) the gitlink points to
  79 *    recursively.
  80 *
  81 * However, it's unclear whether there is really ever any
  82 * reason to see superprojects and subprojects as such a
  83 * "unified" object pool (potentially resulting in a totally
  84 * humongous pack - avoiding which was the whole point of
  85 * having gitlinks in the first place!).
  86 *
  87 * So for now, there is just a note that we *could* follow
  88 * the link, and how to do it. Whether it necessarily makes
  89 * any sense what-so-ever to ever do that is another issue.
  90 */
  91static void process_gitlink(struct traversal_context *ctx,
  92                            const unsigned char *sha1,
  93                            struct strbuf *path,
  94                            const char *name)
  95{
  96        /* Nothing to do */
  97}
  98
  99static void process_tree(struct traversal_context *ctx,
 100                         struct tree *tree,
 101                         struct strbuf *base,
 102                         const char *name);
 103
 104static void process_tree_contents(struct traversal_context *ctx,
 105                                  struct tree *tree,
 106                                  struct strbuf *base)
 107{
 108        struct tree_desc desc;
 109        struct name_entry entry;
 110        enum interesting match = ctx->revs->diffopt.pathspec.nr == 0 ?
 111                all_entries_interesting : entry_not_interesting;
 112
 113        init_tree_desc(&desc, tree->buffer, tree->size);
 114
 115        while (tree_entry(&desc, &entry)) {
 116                if (match != all_entries_interesting) {
 117                        match = tree_entry_interesting(ctx->revs->repo->index,
 118                                                       &entry, base, 0,
 119                                                       &ctx->revs->diffopt.pathspec);
 120                        if (match == all_entries_not_interesting)
 121                                break;
 122                        if (match == entry_not_interesting)
 123                                continue;
 124                }
 125
 126                if (S_ISDIR(entry.mode)) {
 127                        struct tree *t = lookup_tree(ctx->revs->repo, &entry.oid);
 128                        t->object.flags |= NOT_USER_GIVEN;
 129                        process_tree(ctx, t, base, entry.path);
 130                }
 131                else if (S_ISGITLINK(entry.mode))
 132                        process_gitlink(ctx, entry.oid.hash,
 133                                        base, entry.path);
 134                else {
 135                        struct blob *b = lookup_blob(ctx->revs->repo, &entry.oid);
 136                        if (!b) {
 137                                die(_("entry '%s' in tree %s has blob mode, "
 138                                      "but is not a blob"),
 139                                    entry.path, oid_to_hex(&tree->object.oid));
 140                        }
 141                        b->object.flags |= NOT_USER_GIVEN;
 142                        process_blob(ctx, b, base, entry.path);
 143                }
 144        }
 145}
 146
 147static void process_tree(struct traversal_context *ctx,
 148                         struct tree *tree,
 149                         struct strbuf *base,
 150                         const char *name)
 151{
 152        struct object *obj = &tree->object;
 153        struct rev_info *revs = ctx->revs;
 154        int baselen = base->len;
 155        enum list_objects_filter_result r = LOFR_MARK_SEEN | LOFR_DO_SHOW;
 156        int failed_parse;
 157
 158        if (!revs->tree_objects)
 159                return;
 160        if (!obj)
 161                die("bad tree object");
 162        if (obj->flags & (UNINTERESTING | SEEN))
 163                return;
 164
 165        failed_parse = parse_tree_gently(tree, 1);
 166        if (failed_parse) {
 167                if (revs->ignore_missing_links)
 168                        return;
 169
 170                /*
 171                 * Pre-filter known-missing tree objects when explicitly
 172                 * requested.  This may cause the actual filter to report
 173                 * an incomplete list of missing objects.
 174                 */
 175                if (revs->exclude_promisor_objects &&
 176                    is_promisor_object(&obj->oid))
 177                        return;
 178
 179                if (!revs->do_not_die_on_missing_tree)
 180                        die("bad tree object %s", oid_to_hex(&obj->oid));
 181        }
 182
 183        strbuf_addstr(base, name);
 184        if ((obj->flags & NOT_USER_GIVEN) && ctx->filter_fn)
 185                r = ctx->filter_fn(ctx->revs->repo,
 186                                   LOFS_BEGIN_TREE, obj,
 187                                   base->buf, &base->buf[baselen],
 188                                   ctx->filter_data);
 189        if (r & LOFR_MARK_SEEN)
 190                obj->flags |= SEEN;
 191        if (r & LOFR_DO_SHOW)
 192                ctx->show_object(obj, base->buf, ctx->show_data);
 193        if (base->len)
 194                strbuf_addch(base, '/');
 195
 196        if (r & LOFR_SKIP_TREE)
 197                trace_printf("Skipping contents of tree %s...\n", base->buf);
 198        else if (!failed_parse)
 199                process_tree_contents(ctx, tree, base);
 200
 201        if ((obj->flags & NOT_USER_GIVEN) && ctx->filter_fn) {
 202                r = ctx->filter_fn(ctx->revs->repo,
 203                                   LOFS_END_TREE, obj,
 204                                   base->buf, &base->buf[baselen],
 205                                   ctx->filter_data);
 206                if (r & LOFR_MARK_SEEN)
 207                        obj->flags |= SEEN;
 208                if (r & LOFR_DO_SHOW)
 209                        ctx->show_object(obj, base->buf, ctx->show_data);
 210        }
 211
 212        strbuf_setlen(base, baselen);
 213        free_tree_buffer(tree);
 214}
 215
 216static void mark_edge_parents_uninteresting(struct commit *commit,
 217                                            struct rev_info *revs,
 218                                            show_edge_fn show_edge)
 219{
 220        struct commit_list *parents;
 221
 222        for (parents = commit->parents; parents; parents = parents->next) {
 223                struct commit *parent = parents->item;
 224                if (!(parent->object.flags & UNINTERESTING))
 225                        continue;
 226                mark_tree_uninteresting(revs->repo, get_commit_tree(parent));
 227                if (revs->edge_hint && !(parent->object.flags & SHOWN)) {
 228                        parent->object.flags |= SHOWN;
 229                        show_edge(parent);
 230                }
 231        }
 232}
 233
 234static void add_edge_parents(struct commit *commit,
 235                             struct rev_info *revs,
 236                             show_edge_fn show_edge,
 237                             struct oidset *set)
 238{
 239        struct commit_list *parents;
 240
 241        for (parents = commit->parents; parents; parents = parents->next) {
 242                struct commit *parent = parents->item;
 243                struct tree *tree = get_commit_tree(parent);
 244
 245                if (!tree)
 246                        continue;
 247
 248                oidset_insert(set, &tree->object.oid);
 249
 250                if (!(parent->object.flags & UNINTERESTING))
 251                        continue;
 252                tree->object.flags |= UNINTERESTING;
 253
 254                if (revs->edge_hint && !(parent->object.flags & SHOWN)) {
 255                        parent->object.flags |= SHOWN;
 256                        show_edge(parent);
 257                }
 258        }
 259}
 260
 261void mark_edges_uninteresting(struct rev_info *revs,
 262                              show_edge_fn show_edge,
 263                              int sparse)
 264{
 265        struct commit_list *list;
 266        int i;
 267
 268        if (sparse) {
 269                struct oidset set;
 270                oidset_init(&set, 16);
 271
 272                for (list = revs->commits; list; list = list->next) {
 273                        struct commit *commit = list->item;
 274                        struct tree *tree = get_commit_tree(commit);
 275
 276                        if (commit->object.flags & UNINTERESTING)
 277                                tree->object.flags |= UNINTERESTING;
 278
 279                        oidset_insert(&set, &tree->object.oid);
 280                        add_edge_parents(commit, revs, show_edge, &set);
 281                }
 282
 283                mark_trees_uninteresting_sparse(revs->repo, &set);
 284                oidset_clear(&set);
 285        } else {
 286                for (list = revs->commits; list; list = list->next) {
 287                        struct commit *commit = list->item;
 288                        if (commit->object.flags & UNINTERESTING) {
 289                                mark_tree_uninteresting(revs->repo,
 290                                                        get_commit_tree(commit));
 291                                if (revs->edge_hint_aggressive && !(commit->object.flags & SHOWN)) {
 292                                        commit->object.flags |= SHOWN;
 293                                        show_edge(commit);
 294                                }
 295                                continue;
 296                        }
 297                        mark_edge_parents_uninteresting(commit, revs, show_edge);
 298                }
 299        }
 300
 301        if (revs->edge_hint_aggressive) {
 302                for (i = 0; i < revs->cmdline.nr; i++) {
 303                        struct object *obj = revs->cmdline.rev[i].item;
 304                        struct commit *commit = (struct commit *)obj;
 305                        if (obj->type != OBJ_COMMIT || !(obj->flags & UNINTERESTING))
 306                                continue;
 307                        mark_tree_uninteresting(revs->repo,
 308                                                get_commit_tree(commit));
 309                        if (!(obj->flags & SHOWN)) {
 310                                obj->flags |= SHOWN;
 311                                show_edge(commit);
 312                        }
 313                }
 314        }
 315}
 316
 317static void add_pending_tree(struct rev_info *revs, struct tree *tree)
 318{
 319        add_pending_object(revs, &tree->object, "");
 320}
 321
 322static void traverse_trees_and_blobs(struct traversal_context *ctx,
 323                                     struct strbuf *base)
 324{
 325        int i;
 326
 327        assert(base->len == 0);
 328
 329        for (i = 0; i < ctx->revs->pending.nr; i++) {
 330                struct object_array_entry *pending = ctx->revs->pending.objects + i;
 331                struct object *obj = pending->item;
 332                const char *name = pending->name;
 333                const char *path = pending->path;
 334                if (obj->flags & (UNINTERESTING | SEEN))
 335                        continue;
 336                if (obj->type == OBJ_TAG) {
 337                        obj->flags |= SEEN;
 338                        ctx->show_object(obj, name, ctx->show_data);
 339                        continue;
 340                }
 341                if (!path)
 342                        path = "";
 343                if (obj->type == OBJ_TREE) {
 344                        process_tree(ctx, (struct tree *)obj, base, path);
 345                        continue;
 346                }
 347                if (obj->type == OBJ_BLOB) {
 348                        process_blob(ctx, (struct blob *)obj, base, path);
 349                        continue;
 350                }
 351                die("unknown pending object %s (%s)",
 352                    oid_to_hex(&obj->oid), name);
 353        }
 354        object_array_clear(&ctx->revs->pending);
 355}
 356
 357static void do_traverse(struct traversal_context *ctx)
 358{
 359        struct commit *commit;
 360        struct strbuf csp; /* callee's scratch pad */
 361        strbuf_init(&csp, PATH_MAX);
 362
 363        while ((commit = get_revision(ctx->revs)) != NULL) {
 364                /*
 365                 * an uninteresting boundary commit may not have its tree
 366                 * parsed yet, but we are not going to show them anyway
 367                 */
 368                if (get_commit_tree(commit)) {
 369                        struct tree *tree = get_commit_tree(commit);
 370                        tree->object.flags |= NOT_USER_GIVEN;
 371                        add_pending_tree(ctx->revs, tree);
 372                }
 373                ctx->show_commit(commit, ctx->show_data);
 374
 375                if (ctx->revs->tree_blobs_in_commit_order)
 376                        /*
 377                         * NEEDSWORK: Adding the tree and then flushing it here
 378                         * needs a reallocation for each commit. Can we pass the
 379                         * tree directory without allocation churn?
 380                         */
 381                        traverse_trees_and_blobs(ctx, &csp);
 382        }
 383        traverse_trees_and_blobs(ctx, &csp);
 384        strbuf_release(&csp);
 385}
 386
 387void traverse_commit_list(struct rev_info *revs,
 388                          show_commit_fn show_commit,
 389                          show_object_fn show_object,
 390                          void *show_data)
 391{
 392        struct traversal_context ctx;
 393        ctx.revs = revs;
 394        ctx.show_commit = show_commit;
 395        ctx.show_object = show_object;
 396        ctx.show_data = show_data;
 397        ctx.filter_fn = NULL;
 398        ctx.filter_data = NULL;
 399        do_traverse(&ctx);
 400}
 401
 402void traverse_commit_list_filtered(
 403        struct list_objects_filter_options *filter_options,
 404        struct rev_info *revs,
 405        show_commit_fn show_commit,
 406        show_object_fn show_object,
 407        void *show_data,
 408        struct oidset *omitted)
 409{
 410        struct traversal_context ctx;
 411        filter_free_fn filter_free_fn = NULL;
 412
 413        ctx.revs = revs;
 414        ctx.show_object = show_object;
 415        ctx.show_commit = show_commit;
 416        ctx.show_data = show_data;
 417        ctx.filter_fn = NULL;
 418
 419        ctx.filter_data = list_objects_filter__init(omitted, filter_options,
 420                                                    &ctx.filter_fn, &filter_free_fn);
 421        do_traverse(&ctx);
 422        if (ctx.filter_data && filter_free_fn)
 423                filter_free_fn(ctx.filter_data);
 424}