config.mak.devon commit general improvements (43abf13)
   1ifeq ($(filter no-error,$(DEVOPTS)),)
   2DEVELOPER_CFLAGS += -Werror
   3endif
   4ifneq ($(filter pedantic,$(DEVOPTS)),)
   5DEVELOPER_CFLAGS += -pedantic
   6# don't warn for each N_ use
   7DEVELOPER_CFLAGS += -DUSE_PARENS_AROUND_GETTEXT_N=0
   8endif
   9DEVELOPER_CFLAGS += -Wall
  10DEVELOPER_CFLAGS += -Wdeclaration-after-statement
  11DEVELOPER_CFLAGS += -Wformat-security
  12DEVELOPER_CFLAGS += -Wno-format-zero-length
  13DEVELOPER_CFLAGS += -Wold-style-definition
  14DEVELOPER_CFLAGS += -Woverflow
  15DEVELOPER_CFLAGS += -Wpointer-arith
  16DEVELOPER_CFLAGS += -Wstrict-prototypes
  17DEVELOPER_CFLAGS += -Wunused
  18DEVELOPER_CFLAGS += -Wvla
  19
  20ifndef COMPILER_FEATURES
  21COMPILER_FEATURES := $(shell ./detect-compiler $(CC))
  22endif
  23
  24ifneq ($(filter clang4,$(COMPILER_FEATURES)),)
  25DEVELOPER_CFLAGS += -Wtautological-constant-out-of-range-compare
  26endif
  27
  28ifneq ($(or $(filter gcc6,$(COMPILER_FEATURES)),$(filter clang4,$(COMPILER_FEATURES))),)
  29DEVELOPER_CFLAGS += -Wextra
  30# if a function is public, there should be a prototype and the right
  31# header file should be included. If not, it should be static.
  32DEVELOPER_CFLAGS += -Wmissing-prototypes
  33ifeq ($(filter extra-all,$(DEVOPTS)),)
  34# These are disabled because we have these all over the place.
  35DEVELOPER_CFLAGS += -Wno-empty-body
  36DEVELOPER_CFLAGS += -Wno-missing-field-initializers
  37DEVELOPER_CFLAGS += -Wno-sign-compare
  38DEVELOPER_CFLAGS += -Wno-unused-parameter
  39endif
  40endif
  41
  42# uninitialized warnings on gcc 4.9.2 in xdiff/xdiffi.c and config.c
  43# not worth fixing since newer compilers correctly stop complaining
  44ifneq ($(filter gcc4,$(COMPILER_FEATURES)),)
  45ifeq ($(filter gcc5,$(COMPILER_FEATURES)),)
  46DEVELOPER_CFLAGS += -Wno-uninitialized
  47endif
  48endif