t / t5100 / 0010on commit contrib: add 'git difftool' for launching common merge tools (5c38ea3)
   1From b9704a518e21158433baa2cc2d591fea687967f6 Mon Sep 17 00:00:00 2001
   2From: =?UTF-8?q?Lukas=20Sandstr=C3=B6m?= <lukass@etek.chalmers.se>
   3Date: Thu, 10 Jul 2008 23:41:33 +0200
   4Subject: Re: discussion that lead to this patch
   5MIME-Version: 1.0
   6Content-Type: text/plain; charset=UTF-8
   7Content-Transfer-Encoding: 8bit
   8
   9[PATCH] git-mailinfo: Fix getting the subject from the body
  10
  11"Subject: " isn't in the static array "header", and thus
  12memcmp("Subject: ", header[i], 7) will never match.
  13
  14Signed-off-by: Lukas Sandström <lukass@etek.chalmers.se>
  15Signed-off-by: Junio C Hamano <gitster@pobox.com>
  16---
  17 builtin-mailinfo.c |    2 +-
  18 1 files changed, 1 insertions(+), 1 deletions(-)
  19
  20diff --git a/builtin-mailinfo.c b/builtin-mailinfo.c
  21index 962aa34..2d1520f 100644
  22--- a/builtin-mailinfo.c
  23+++ b/builtin-mailinfo.c
  24@@ -334,7 +334,7 @@ static int check_header(char *line, unsigned linesize, char **hdr_data, int over
  25                return 1;
  26        if (!memcmp("[PATCH]", line, 7) && isspace(line[7])) {
  27                for (i = 0; header[i]; i++) {
  28-                       if (!memcmp("Subject: ", header[i], 9)) {
  29+                       if (!memcmp("Subject", header[i], 7)) {
  30                                if (! handle_header(line, hdr_data[i], 0)) {
  31                                        return 1;
  32                                }
  33-- 
  341.5.6.2.455.g1efb2
  35