builtin / config.con commit git-config: fix regexp memory leaks on error conditions (97ed50f)
   1#include "builtin.h"
   2#include "cache.h"
   3#include "color.h"
   4#include "parse-options.h"
   5
   6static const char *const builtin_config_usage[] = {
   7        N_("git config [options]"),
   8        NULL
   9};
  10
  11static char *key;
  12static regex_t *key_regexp;
  13static regex_t *regexp;
  14static int show_keys;
  15static int use_key_regexp;
  16static int do_all;
  17static int do_not_match;
  18static int seen;
  19static char delim = '=';
  20static char key_delim = ' ';
  21static char term = '\n';
  22
  23static int use_global_config, use_system_config, use_local_config;
  24static const char *given_config_file;
  25static int actions, types;
  26static const char *get_color_slot, *get_colorbool_slot;
  27static int end_null;
  28static int respect_includes = -1;
  29
  30#define ACTION_GET (1<<0)
  31#define ACTION_GET_ALL (1<<1)
  32#define ACTION_GET_REGEXP (1<<2)
  33#define ACTION_REPLACE_ALL (1<<3)
  34#define ACTION_ADD (1<<4)
  35#define ACTION_UNSET (1<<5)
  36#define ACTION_UNSET_ALL (1<<6)
  37#define ACTION_RENAME_SECTION (1<<7)
  38#define ACTION_REMOVE_SECTION (1<<8)
  39#define ACTION_LIST (1<<9)
  40#define ACTION_EDIT (1<<10)
  41#define ACTION_SET (1<<11)
  42#define ACTION_SET_ALL (1<<12)
  43#define ACTION_GET_COLOR (1<<13)
  44#define ACTION_GET_COLORBOOL (1<<14)
  45
  46#define TYPE_BOOL (1<<0)
  47#define TYPE_INT (1<<1)
  48#define TYPE_BOOL_OR_INT (1<<2)
  49#define TYPE_PATH (1<<3)
  50
  51static struct option builtin_config_options[] = {
  52        OPT_GROUP(N_("Config file location")),
  53        OPT_BOOLEAN(0, "global", &use_global_config, N_("use global config file")),
  54        OPT_BOOLEAN(0, "system", &use_system_config, N_("use system config file")),
  55        OPT_BOOLEAN(0, "local", &use_local_config, N_("use repository config file")),
  56        OPT_STRING('f', "file", &given_config_file, N_("file"), N_("use given config file")),
  57        OPT_GROUP(N_("Action")),
  58        OPT_BIT(0, "get", &actions, N_("get value: name [value-regex]"), ACTION_GET),
  59        OPT_BIT(0, "get-all", &actions, N_("get all values: key [value-regex]"), ACTION_GET_ALL),
  60        OPT_BIT(0, "get-regexp", &actions, N_("get values for regexp: name-regex [value-regex]"), ACTION_GET_REGEXP),
  61        OPT_BIT(0, "replace-all", &actions, N_("replace all matching variables: name value [value_regex]"), ACTION_REPLACE_ALL),
  62        OPT_BIT(0, "add", &actions, N_("add a new variable: name value"), ACTION_ADD),
  63        OPT_BIT(0, "unset", &actions, N_("remove a variable: name [value-regex]"), ACTION_UNSET),
  64        OPT_BIT(0, "unset-all", &actions, N_("remove all matches: name [value-regex]"), ACTION_UNSET_ALL),
  65        OPT_BIT(0, "rename-section", &actions, N_("rename section: old-name new-name"), ACTION_RENAME_SECTION),
  66        OPT_BIT(0, "remove-section", &actions, N_("remove a section: name"), ACTION_REMOVE_SECTION),
  67        OPT_BIT('l', "list", &actions, N_("list all"), ACTION_LIST),
  68        OPT_BIT('e', "edit", &actions, N_("open an editor"), ACTION_EDIT),
  69        OPT_STRING(0, "get-color", &get_color_slot, N_("slot"), N_("find the color configured: [default]")),
  70        OPT_STRING(0, "get-colorbool", &get_colorbool_slot, N_("slot"), N_("find the color setting: [stdout-is-tty]")),
  71        OPT_GROUP(N_("Type")),
  72        OPT_BIT(0, "bool", &types, N_("value is \"true\" or \"false\""), TYPE_BOOL),
  73        OPT_BIT(0, "int", &types, N_("value is decimal number"), TYPE_INT),
  74        OPT_BIT(0, "bool-or-int", &types, N_("value is --bool or --int"), TYPE_BOOL_OR_INT),
  75        OPT_BIT(0, "path", &types, N_("value is a path (file or directory name)"), TYPE_PATH),
  76        OPT_GROUP(N_("Other")),
  77        OPT_BOOLEAN('z', "null", &end_null, N_("terminate values with NUL byte")),
  78        OPT_BOOL(0, "includes", &respect_includes, N_("respect include directives on lookup")),
  79        OPT_END(),
  80};
  81
  82static void check_argc(int argc, int min, int max) {
  83        if (argc >= min && argc <= max)
  84                return;
  85        error("wrong number of arguments");
  86        usage_with_options(builtin_config_usage, builtin_config_options);
  87}
  88
  89static int show_all_config(const char *key_, const char *value_, void *cb)
  90{
  91        if (value_)
  92                printf("%s%c%s%c", key_, delim, value_, term);
  93        else
  94                printf("%s%c", key_, term);
  95        return 0;
  96}
  97
  98static int show_config(const char *key_, const char *value_, void *cb)
  99{
 100        char value[256];
 101        const char *vptr = value;
 102        int must_free_vptr = 0;
 103        int dup_error = 0;
 104        int must_print_delim = 0;
 105
 106        if (!use_key_regexp && strcmp(key_, key))
 107                return 0;
 108        if (use_key_regexp && regexec(key_regexp, key_, 0, NULL, 0))
 109                return 0;
 110        if (regexp != NULL &&
 111            (do_not_match ^ !!regexec(regexp, (value_?value_:""), 0, NULL, 0)))
 112                return 0;
 113
 114        if (show_keys) {
 115                printf("%s", key_);
 116                must_print_delim = 1;
 117        }
 118        if (seen && !do_all)
 119                dup_error = 1;
 120        if (types == TYPE_INT)
 121                sprintf(value, "%d", git_config_int(key_, value_?value_:""));
 122        else if (types == TYPE_BOOL)
 123                vptr = git_config_bool(key_, value_) ? "true" : "false";
 124        else if (types == TYPE_BOOL_OR_INT) {
 125                int is_bool, v;
 126                v = git_config_bool_or_int(key_, value_, &is_bool);
 127                if (is_bool)
 128                        vptr = v ? "true" : "false";
 129                else
 130                        sprintf(value, "%d", v);
 131        } else if (types == TYPE_PATH) {
 132                git_config_pathname(&vptr, key_, value_);
 133                must_free_vptr = 1;
 134        } else if (value_) {
 135                vptr = value_;
 136        } else {
 137                /* Just show the key name */
 138                vptr = "";
 139                must_print_delim = 0;
 140        }
 141        seen++;
 142        if (dup_error) {
 143                error("More than one value for the key %s: %s",
 144                                key_, vptr);
 145        }
 146        else {
 147                if (must_print_delim)
 148                        printf("%c", key_delim);
 149                printf("%s%c", vptr, term);
 150        }
 151        if (must_free_vptr)
 152                /* If vptr must be freed, it's a pointer to a
 153                 * dynamically allocated buffer, it's safe to cast to
 154                 * const.
 155                */
 156                free((char *)vptr);
 157
 158        return 0;
 159}
 160
 161static int get_value(const char *key_, const char *regex_)
 162{
 163        int ret = CONFIG_GENERIC_ERROR;
 164        char *global = NULL, *xdg = NULL, *repo_config = NULL;
 165        const char *system_wide = NULL, *local;
 166        struct config_include_data inc = CONFIG_INCLUDE_INIT;
 167        config_fn_t fn;
 168        void *data;
 169
 170        local = given_config_file;
 171        if (!local) {
 172                local = repo_config = git_pathdup("config");
 173                if (git_config_system())
 174                        system_wide = git_etc_gitconfig();
 175                home_config_paths(&global, &xdg, "config");
 176        }
 177
 178        if (use_key_regexp) {
 179                char *tl;
 180
 181                /*
 182                 * NEEDSWORK: this naive pattern lowercasing obviously does not
 183                 * work for more complex patterns like "^[^.]*Foo.*bar".
 184                 * Perhaps we should deprecate this altogether someday.
 185                 */
 186
 187                key = xstrdup(key_);
 188                for (tl = key + strlen(key) - 1;
 189                     tl >= key && *tl != '.';
 190                     tl--)
 191                        *tl = tolower(*tl);
 192                for (tl = key; *tl && *tl != '.'; tl++)
 193                        *tl = tolower(*tl);
 194
 195                key_regexp = (regex_t*)xmalloc(sizeof(regex_t));
 196                if (regcomp(key_regexp, key, REG_EXTENDED)) {
 197                        fprintf(stderr, "Invalid key pattern: %s\n", key_);
 198                        free(key_regexp);
 199                        key_regexp = NULL;
 200                        ret = CONFIG_INVALID_PATTERN;
 201                        goto free_strings;
 202                }
 203        } else {
 204                if (git_config_parse_key(key_, &key, NULL)) {
 205                        ret = CONFIG_INVALID_KEY;
 206                        goto free_strings;
 207                }
 208        }
 209
 210        if (regex_) {
 211                if (regex_[0] == '!') {
 212                        do_not_match = 1;
 213                        regex_++;
 214                }
 215
 216                regexp = (regex_t*)xmalloc(sizeof(regex_t));
 217                if (regcomp(regexp, regex_, REG_EXTENDED)) {
 218                        fprintf(stderr, "Invalid pattern: %s\n", regex_);
 219                        free(regexp);
 220                        regexp = NULL;
 221                        ret = CONFIG_INVALID_PATTERN;
 222                        goto free_strings;
 223                }
 224        }
 225
 226        fn = show_config;
 227        data = NULL;
 228        if (respect_includes) {
 229                inc.fn = fn;
 230                inc.data = data;
 231                fn = git_config_include;
 232                data = &inc;
 233        }
 234
 235        if (do_all && system_wide)
 236                git_config_from_file(fn, system_wide, data);
 237        if (do_all && xdg)
 238                git_config_from_file(fn, xdg, data);
 239        if (do_all && global)
 240                git_config_from_file(fn, global, data);
 241        if (do_all)
 242                git_config_from_file(fn, local, data);
 243        git_config_from_parameters(fn, data);
 244        if (!do_all && !seen)
 245                git_config_from_file(fn, local, data);
 246        if (!do_all && !seen && global)
 247                git_config_from_file(fn, global, data);
 248        if (!do_all && !seen && xdg)
 249                git_config_from_file(fn, xdg, data);
 250        if (!do_all && !seen && system_wide)
 251                git_config_from_file(fn, system_wide, data);
 252
 253        if (do_all)
 254                ret = !seen;
 255        else
 256                ret = (seen == 1) ? 0 : seen > 1 ? 2 : 1;
 257
 258free_strings:
 259        free(repo_config);
 260        free(global);
 261        free(xdg);
 262        free(key);
 263        if (key_regexp) {
 264                regfree(key_regexp);
 265                free(key_regexp);
 266        }
 267        if (regexp) {
 268                regfree(regexp);
 269                free(regexp);
 270        }
 271
 272        return ret;
 273}
 274
 275static char *normalize_value(const char *key, const char *value)
 276{
 277        char *normalized;
 278
 279        if (!value)
 280                return NULL;
 281
 282        if (types == 0 || types == TYPE_PATH)
 283                /*
 284                 * We don't do normalization for TYPE_PATH here: If
 285                 * the path is like ~/foobar/, we prefer to store
 286                 * "~/foobar/" in the config file, and to expand the ~
 287                 * when retrieving the value.
 288                 */
 289                normalized = xstrdup(value);
 290        else {
 291                normalized = xmalloc(64);
 292                if (types == TYPE_INT) {
 293                        int v = git_config_int(key, value);
 294                        sprintf(normalized, "%d", v);
 295                }
 296                else if (types == TYPE_BOOL)
 297                        sprintf(normalized, "%s",
 298                                git_config_bool(key, value) ? "true" : "false");
 299                else if (types == TYPE_BOOL_OR_INT) {
 300                        int is_bool, v;
 301                        v = git_config_bool_or_int(key, value, &is_bool);
 302                        if (!is_bool)
 303                                sprintf(normalized, "%d", v);
 304                        else
 305                                sprintf(normalized, "%s", v ? "true" : "false");
 306                }
 307        }
 308
 309        return normalized;
 310}
 311
 312static int get_color_found;
 313static const char *get_color_slot;
 314static const char *get_colorbool_slot;
 315static char parsed_color[COLOR_MAXLEN];
 316
 317static int git_get_color_config(const char *var, const char *value, void *cb)
 318{
 319        if (!strcmp(var, get_color_slot)) {
 320                if (!value)
 321                        config_error_nonbool(var);
 322                color_parse(value, var, parsed_color);
 323                get_color_found = 1;
 324        }
 325        return 0;
 326}
 327
 328static void get_color(const char *def_color)
 329{
 330        get_color_found = 0;
 331        parsed_color[0] = '\0';
 332        git_config_with_options(git_get_color_config, NULL,
 333                                given_config_file, respect_includes);
 334
 335        if (!get_color_found && def_color)
 336                color_parse(def_color, "command line", parsed_color);
 337
 338        fputs(parsed_color, stdout);
 339}
 340
 341static int get_colorbool_found;
 342static int get_diff_color_found;
 343static int get_color_ui_found;
 344static int git_get_colorbool_config(const char *var, const char *value,
 345                void *cb)
 346{
 347        if (!strcmp(var, get_colorbool_slot))
 348                get_colorbool_found = git_config_colorbool(var, value);
 349        else if (!strcmp(var, "diff.color"))
 350                get_diff_color_found = git_config_colorbool(var, value);
 351        else if (!strcmp(var, "color.ui"))
 352                get_color_ui_found = git_config_colorbool(var, value);
 353        return 0;
 354}
 355
 356static int get_colorbool(int print)
 357{
 358        get_colorbool_found = -1;
 359        get_diff_color_found = -1;
 360        git_config_with_options(git_get_colorbool_config, NULL,
 361                                given_config_file, respect_includes);
 362
 363        if (get_colorbool_found < 0) {
 364                if (!strcmp(get_colorbool_slot, "color.diff"))
 365                        get_colorbool_found = get_diff_color_found;
 366                if (get_colorbool_found < 0)
 367                        get_colorbool_found = get_color_ui_found;
 368        }
 369
 370        get_colorbool_found = want_color(get_colorbool_found);
 371
 372        if (print) {
 373                printf("%s\n", get_colorbool_found ? "true" : "false");
 374                return 0;
 375        } else
 376                return get_colorbool_found ? 0 : 1;
 377}
 378
 379int cmd_config(int argc, const char **argv, const char *prefix)
 380{
 381        int nongit = !startup_info->have_repository;
 382        char *value;
 383
 384        given_config_file = getenv(CONFIG_ENVIRONMENT);
 385
 386        argc = parse_options(argc, argv, prefix, builtin_config_options,
 387                             builtin_config_usage,
 388                             PARSE_OPT_STOP_AT_NON_OPTION);
 389
 390        if (use_global_config + use_system_config + use_local_config + !!given_config_file > 1) {
 391                error("only one config file at a time.");
 392                usage_with_options(builtin_config_usage, builtin_config_options);
 393        }
 394
 395        if (use_global_config) {
 396                char *user_config = NULL;
 397                char *xdg_config = NULL;
 398
 399                home_config_paths(&user_config, &xdg_config, "config");
 400
 401                if (!user_config)
 402                        /*
 403                         * It is unknown if HOME/.gitconfig exists, so
 404                         * we do not know if we should write to XDG
 405                         * location; error out even if XDG_CONFIG_HOME
 406                         * is set and points at a sane location.
 407                         */
 408                        die("$HOME not set");
 409
 410                if (access_or_warn(user_config, R_OK) &&
 411                    xdg_config && !access_or_warn(xdg_config, R_OK))
 412                        given_config_file = xdg_config;
 413                else
 414                        given_config_file = user_config;
 415        }
 416        else if (use_system_config)
 417                given_config_file = git_etc_gitconfig();
 418        else if (use_local_config)
 419                given_config_file = git_pathdup("config");
 420        else if (given_config_file) {
 421                if (!is_absolute_path(given_config_file) && prefix)
 422                        given_config_file =
 423                                xstrdup(prefix_filename(prefix,
 424                                                        strlen(prefix),
 425                                                        given_config_file));
 426        }
 427
 428        if (respect_includes == -1)
 429                respect_includes = !given_config_file;
 430
 431        if (end_null) {
 432                term = '\0';
 433                delim = '\n';
 434                key_delim = '\n';
 435        }
 436
 437        if (HAS_MULTI_BITS(types)) {
 438                error("only one type at a time.");
 439                usage_with_options(builtin_config_usage, builtin_config_options);
 440        }
 441
 442        if (get_color_slot)
 443            actions |= ACTION_GET_COLOR;
 444        if (get_colorbool_slot)
 445            actions |= ACTION_GET_COLORBOOL;
 446
 447        if ((get_color_slot || get_colorbool_slot) && types) {
 448                error("--get-color and variable type are incoherent");
 449                usage_with_options(builtin_config_usage, builtin_config_options);
 450        }
 451
 452        if (HAS_MULTI_BITS(actions)) {
 453                error("only one action at a time.");
 454                usage_with_options(builtin_config_usage, builtin_config_options);
 455        }
 456        if (actions == 0)
 457                switch (argc) {
 458                case 1: actions = ACTION_GET; break;
 459                case 2: actions = ACTION_SET; break;
 460                case 3: actions = ACTION_SET_ALL; break;
 461                default:
 462                        usage_with_options(builtin_config_usage, builtin_config_options);
 463                }
 464
 465        if (actions == ACTION_LIST) {
 466                check_argc(argc, 0, 0);
 467                if (git_config_with_options(show_all_config, NULL,
 468                                            given_config_file,
 469                                            respect_includes) < 0) {
 470                        if (given_config_file)
 471                                die_errno("unable to read config file '%s'",
 472                                          given_config_file);
 473                        else
 474                                die("error processing config file(s)");
 475                }
 476        }
 477        else if (actions == ACTION_EDIT) {
 478                check_argc(argc, 0, 0);
 479                if (!given_config_file && nongit)
 480                        die("not in a git directory");
 481                git_config(git_default_config, NULL);
 482                launch_editor(given_config_file ?
 483                              given_config_file : git_path("config"),
 484                              NULL, NULL);
 485        }
 486        else if (actions == ACTION_SET) {
 487                int ret;
 488                check_argc(argc, 2, 2);
 489                value = normalize_value(argv[0], argv[1]);
 490                ret = git_config_set_in_file(given_config_file, argv[0], value);
 491                if (ret == CONFIG_NOTHING_SET)
 492                        error("cannot overwrite multiple values with a single value\n"
 493                        "       Use a regexp, --add or --replace-all to change %s.", argv[0]);
 494                return ret;
 495        }
 496        else if (actions == ACTION_SET_ALL) {
 497                check_argc(argc, 2, 3);
 498                value = normalize_value(argv[0], argv[1]);
 499                return git_config_set_multivar_in_file(given_config_file,
 500                                                       argv[0], value, argv[2], 0);
 501        }
 502        else if (actions == ACTION_ADD) {
 503                check_argc(argc, 2, 2);
 504                value = normalize_value(argv[0], argv[1]);
 505                return git_config_set_multivar_in_file(given_config_file,
 506                                                       argv[0], value, "^$", 0);
 507        }
 508        else if (actions == ACTION_REPLACE_ALL) {
 509                check_argc(argc, 2, 3);
 510                value = normalize_value(argv[0], argv[1]);
 511                return git_config_set_multivar_in_file(given_config_file,
 512                                                       argv[0], value, argv[2], 1);
 513        }
 514        else if (actions == ACTION_GET) {
 515                check_argc(argc, 1, 2);
 516                return get_value(argv[0], argv[1]);
 517        }
 518        else if (actions == ACTION_GET_ALL) {
 519                do_all = 1;
 520                check_argc(argc, 1, 2);
 521                return get_value(argv[0], argv[1]);
 522        }
 523        else if (actions == ACTION_GET_REGEXP) {
 524                show_keys = 1;
 525                use_key_regexp = 1;
 526                do_all = 1;
 527                check_argc(argc, 1, 2);
 528                return get_value(argv[0], argv[1]);
 529        }
 530        else if (actions == ACTION_UNSET) {
 531                check_argc(argc, 1, 2);
 532                if (argc == 2)
 533                        return git_config_set_multivar_in_file(given_config_file,
 534                                                               argv[0], NULL, argv[1], 0);
 535                else
 536                        return git_config_set_in_file(given_config_file,
 537                                                      argv[0], NULL);
 538        }
 539        else if (actions == ACTION_UNSET_ALL) {
 540                check_argc(argc, 1, 2);
 541                return git_config_set_multivar_in_file(given_config_file,
 542                                                       argv[0], NULL, argv[1], 1);
 543        }
 544        else if (actions == ACTION_RENAME_SECTION) {
 545                int ret;
 546                check_argc(argc, 2, 2);
 547                ret = git_config_rename_section_in_file(given_config_file,
 548                                                        argv[0], argv[1]);
 549                if (ret < 0)
 550                        return ret;
 551                if (ret == 0)
 552                        die("No such section!");
 553        }
 554        else if (actions == ACTION_REMOVE_SECTION) {
 555                int ret;
 556                check_argc(argc, 1, 1);
 557                ret = git_config_rename_section_in_file(given_config_file,
 558                                                        argv[0], NULL);
 559                if (ret < 0)
 560                        return ret;
 561                if (ret == 0)
 562                        die("No such section!");
 563        }
 564        else if (actions == ACTION_GET_COLOR) {
 565                get_color(argv[0]);
 566        }
 567        else if (actions == ACTION_GET_COLORBOOL) {
 568                if (argc == 1)
 569                        color_stdout_is_tty = git_config_bool("command line", argv[0]);
 570                return get_colorbool(argc != 0);
 571        }
 572
 573        return 0;
 574}
 575
 576int cmd_repo_config(int argc, const char **argv, const char *prefix)
 577{
 578        fprintf(stderr, "WARNING: git repo-config is deprecated in favor of git config.\n");
 579        return cmd_config(argc, argv, prefix);
 580}