combine-diff.con commit combine-diff: update --cc "uninteresting hunks" logic. (bf1c32b)
   1#include "cache.h"
   2#include "commit.h"
   3#include "diff.h"
   4#include "diffcore.h"
   5#include "quote.h"
   6
   7static int uninteresting(struct diff_filepair *p)
   8{
   9        if (diff_unmodified_pair(p))
  10                return 1;
  11        if (!S_ISREG(p->one->mode) || !S_ISREG(p->two->mode))
  12                return 1;
  13        return 0;
  14}
  15
  16static struct combine_diff_path *intersect_paths(struct combine_diff_path *curr, int n, int num_parent)
  17{
  18        struct diff_queue_struct *q = &diff_queued_diff;
  19        struct combine_diff_path *p;
  20        int i;
  21
  22        if (!n) {
  23                struct combine_diff_path *list = NULL, **tail = &list;
  24                for (i = 0; i < q->nr; i++) {
  25                        int len;
  26                        const char *path;
  27                        if (uninteresting(q->queue[i]))
  28                                continue;
  29                        path = q->queue[i]->two->path;
  30                        len = strlen(path);
  31
  32                        p = xmalloc(sizeof(*p) + len + 1 + num_parent * 20);
  33                        p->path = (char*) &(p->parent_sha1[num_parent][0]);
  34                        memcpy(p->path, path, len);
  35                        p->path[len] = 0;
  36                        p->len = len;
  37                        p->next = NULL;
  38                        memcpy(p->sha1, q->queue[i]->two->sha1, 20);
  39                        memcpy(p->parent_sha1[n], q->queue[i]->one->sha1, 20);
  40                        *tail = p;
  41                        tail = &p->next;
  42                }
  43                return list;
  44        }
  45
  46        for (p = curr; p; p = p->next) {
  47                int found = 0;
  48                if (!p->len)
  49                        continue;
  50                for (i = 0; i < q->nr; i++) {
  51                        const char *path;
  52                        int len;
  53
  54                        if (uninteresting(q->queue[i]))
  55                                continue;
  56                        path = q->queue[i]->two->path;
  57                        len = strlen(path);
  58                        if (len == p->len && !memcmp(path, p->path, len)) {
  59                                found = 1;
  60                                memcpy(p->parent_sha1[n],
  61                                       q->queue[i]->one->sha1, 20);
  62                                break;
  63                        }
  64                }
  65                if (!found)
  66                        p->len = 0;
  67        }
  68        return curr;
  69}
  70
  71struct lline {
  72        struct lline *next;
  73        int len;
  74        unsigned long parent_map;
  75        char line[FLEX_ARRAY];
  76};
  77
  78struct sline {
  79        struct lline *lost_head, **lost_tail;
  80        char *bol;
  81        int len;
  82        unsigned long flag;
  83};
  84
  85static char *grab_blob(const unsigned char *sha1, unsigned long *size)
  86{
  87        char *blob;
  88        char type[20];
  89        if (!memcmp(sha1, null_sha1, 20)) {
  90                /* deleted blob */
  91                *size = 0;
  92                return xcalloc(1, 1);
  93        }
  94        blob = read_sha1_file(sha1, type, size);
  95        if (strcmp(type, "blob"))
  96                die("object '%s' is not a blob!", sha1_to_hex(sha1));
  97        return blob;
  98}
  99
 100#define TMPPATHLEN 50
 101#define MAXLINELEN 10240
 102
 103static void write_to_temp_file(char *tmpfile, void *blob, unsigned long size)
 104{
 105        int fd = git_mkstemp(tmpfile, TMPPATHLEN, ".diff_XXXXXX");
 106        if (fd < 0)
 107                die("unable to create temp-file");
 108        if (write(fd, blob, size) != size)
 109                die("unable to write temp-file");
 110        close(fd);
 111}
 112
 113static void write_temp_blob(char *tmpfile, const unsigned char *sha1)
 114{
 115        unsigned long size;
 116        void *blob;
 117        blob = grab_blob(sha1, &size);
 118        write_to_temp_file(tmpfile, blob, size);
 119        free(blob);
 120}
 121
 122static int parse_num(char **cp_p, unsigned int *num_p)
 123{
 124        char *cp = *cp_p;
 125        unsigned int num = 0;
 126        int read_some;
 127
 128        while ('0' <= *cp && *cp <= '9')
 129                num = num * 10 + *cp++ - '0';
 130        if (!(read_some = cp - *cp_p))
 131                return -1;
 132        *cp_p = cp;
 133        *num_p = num;
 134        return 0;
 135}
 136
 137static int parse_hunk_header(char *line, int len,
 138                             unsigned int *ob, unsigned int *on,
 139                             unsigned int *nb, unsigned int *nn)
 140{
 141        char *cp;
 142        cp = line + 4;
 143        if (parse_num(&cp, ob)) {
 144        bad_line:
 145                return error("malformed diff output: %s", line);
 146        }
 147        if (*cp == ',') {
 148                cp++;
 149                if (parse_num(&cp, on))
 150                        goto bad_line;
 151        }
 152        else
 153                *on = 1;
 154        if (*cp++ != ' ' || *cp++ != '+')
 155                goto bad_line;
 156        if (parse_num(&cp, nb))
 157                goto bad_line;
 158        if (*cp == ',') {
 159                cp++;
 160                if (parse_num(&cp, nn))
 161                        goto bad_line;
 162        }
 163        else
 164                *nn = 1;
 165        return -!!memcmp(cp, " @@", 3);
 166}
 167
 168static void append_lost(struct sline *sline, int n, const char *line)
 169{
 170        struct lline *lline;
 171        int len = strlen(line);
 172        unsigned long this_mask = (1UL<<n);
 173        if (line[len-1] == '\n')
 174                len--;
 175
 176        /* Check to see if we can squash things */
 177        if (sline->lost_head) {
 178                struct lline *last_one = NULL;
 179                /* We cannot squash it with earlier one */
 180                for (lline = sline->lost_head;
 181                     lline;
 182                     lline = lline->next)
 183                        if (lline->parent_map & this_mask)
 184                                last_one = lline;
 185                lline = last_one ? last_one->next : sline->lost_head;
 186                while (lline) {
 187                        if (lline->len == len &&
 188                            !memcmp(lline->line, line, len)) {
 189                                lline->parent_map |= this_mask;
 190                                return;
 191                        }
 192                        lline = lline->next;
 193                }
 194        }
 195
 196        lline = xmalloc(sizeof(*lline) + len + 1);
 197        lline->len = len;
 198        lline->next = NULL;
 199        lline->parent_map = this_mask;
 200        memcpy(lline->line, line, len);
 201        lline->line[len] = 0;
 202        *sline->lost_tail = lline;
 203        sline->lost_tail = &lline->next;
 204}
 205
 206static void combine_diff(const unsigned char *parent, const char *ourtmp,
 207                         struct sline *sline, int cnt, int n)
 208{
 209        FILE *in;
 210        char parent_tmp[TMPPATHLEN];
 211        char cmd[TMPPATHLEN * 2 + 1024];
 212        char line[MAXLINELEN];
 213        unsigned int lno, ob, on, nb, nn;
 214        unsigned long pmask = ~(1UL << n);
 215        struct sline *lost_bucket = NULL;
 216
 217        write_temp_blob(parent_tmp, parent);
 218        sprintf(cmd, "diff --unified=0 -La/x -Lb/x '%s' '%s'",
 219                parent_tmp, ourtmp);
 220        in = popen(cmd, "r");
 221        if (!in)
 222                return;
 223
 224        lno = 1;
 225        while (fgets(line, sizeof(line), in) != NULL) {
 226                int len = strlen(line);
 227                if (5 < len && !memcmp("@@ -", line, 4)) {
 228                        if (parse_hunk_header(line, len,
 229                                              &ob, &on, &nb, &nn))
 230                                break;
 231                        lno = nb;
 232                        if (!nb) {
 233                                /* @@ -1,2 +0,0 @@ to remove the
 234                                 * first two lines...
 235                                 */
 236                                nb = 1;
 237                        }
 238                        lost_bucket = &sline[nb-1]; /* sline is 0 based */
 239                        continue;
 240                }
 241                if (!lost_bucket)
 242                        continue;
 243                switch (line[0]) {
 244                case '-':
 245                        append_lost(lost_bucket, n, line+1);
 246                        break;
 247                case '+':
 248                        sline[lno-1].flag &= pmask;
 249                        lno++;
 250                        break;
 251                }
 252        }
 253        fclose(in);
 254        unlink(parent_tmp);
 255}
 256
 257static unsigned long context = 3;
 258static char combine_marker = '@';
 259
 260static int interesting(struct sline *sline, unsigned long all_mask)
 261{
 262        return ((sline->flag & all_mask) != all_mask || sline->lost_head);
 263}
 264
 265static unsigned long adjust_hunk_tail(struct sline *sline,
 266                                      unsigned long all_mask,
 267                                      unsigned long hunk_begin,
 268                                      unsigned long i)
 269{
 270        /* i points at the first uninteresting line.
 271         * If the last line of the hunk was interesting
 272         * only because it has some deletion, then
 273         * it is not all that interesting for the
 274         * purpose of giving trailing context lines.
 275         */
 276        if ((hunk_begin + 1 <= i) &&
 277            ((sline[i-1].flag & all_mask) == all_mask))
 278                i--;
 279        return i;
 280}
 281
 282static unsigned long next_interesting(struct sline *sline,
 283                                      unsigned long mark,
 284                                      unsigned long i,
 285                                      unsigned long cnt,
 286                                      int uninteresting)
 287{
 288        while (i < cnt)
 289                if (uninteresting ?
 290                    !(sline[i].flag & mark) :
 291                    (sline[i].flag & mark))
 292                        return i;
 293                else
 294                        i++;
 295        return cnt;
 296}
 297
 298static int give_context(struct sline *sline, unsigned long cnt, int num_parent)
 299{
 300        unsigned long all_mask = (1UL<<num_parent) - 1;
 301        unsigned long mark = (1UL<<num_parent);
 302        unsigned long i;
 303
 304        i = next_interesting(sline, mark, 0, cnt, 0);
 305        if (cnt <= i)
 306                return 0;
 307
 308        while (i < cnt) {
 309                unsigned long j = (context < i) ? (i - context) : 0;
 310                unsigned long k;
 311                while (j < i)
 312                        sline[j++].flag |= mark;
 313
 314        again:
 315                j = next_interesting(sline, mark, i, cnt, 1);
 316                if (cnt <= j)
 317                        break; /* the rest are all interesting */
 318
 319                /* lookahead context lines */
 320                k = next_interesting(sline, mark, j, cnt, 0);
 321                j = adjust_hunk_tail(sline, all_mask, i, j);
 322
 323                if (k < j + context) {
 324                        /* k is interesting and [j,k) are not, but
 325                         * paint them interesting because the gap is small.
 326                         */
 327                        while (j < k)
 328                                sline[j++].flag |= mark;
 329                        i = k;
 330                        goto again;
 331                }
 332
 333                /* j is the first uninteresting line and there is
 334                 * no overlap beyond it within context lines.
 335                 */
 336                i = k;
 337                k = (j + context < cnt) ? j + context : cnt;
 338                while (j < k)
 339                        sline[j++].flag |= mark;
 340        }
 341        return 1;
 342}
 343
 344static int make_hunks(struct sline *sline, unsigned long cnt,
 345                       int num_parent, int dense)
 346{
 347        unsigned long all_mask = (1UL<<num_parent) - 1;
 348        unsigned long mark = (1UL<<num_parent);
 349        unsigned long i;
 350        int has_interesting = 0;
 351
 352        for (i = 0; i < cnt; i++) {
 353                if (interesting(&sline[i], all_mask))
 354                        sline[i].flag |= mark;
 355                else
 356                        sline[i].flag &= ~mark;
 357        }
 358        if (!dense)
 359                return give_context(sline, cnt, num_parent);
 360
 361        /* Look at each hunk, and if we have changes from only one
 362         * parent, or the changes are the same from all but one
 363         * parent, mark that uninteresting.
 364         */
 365        i = 0;
 366        while (i < cnt) {
 367                unsigned long j, hunk_begin, hunk_end;
 368                unsigned long same_diff;
 369                while (i < cnt && !(sline[i].flag & mark))
 370                        i++;
 371                if (cnt <= i)
 372                        break; /* No more interesting hunks */
 373                hunk_begin = i;
 374                for (j = i + 1; j < cnt; j++) {
 375                        if (!(sline[j].flag & mark)) {
 376                                /* Look beyond the end to see if there
 377                                 * is an interesting line after this
 378                                 * hunk within context span.
 379                                 */
 380                                unsigned long la; /* lookahead */
 381                                int contin = 0;
 382                                la = adjust_hunk_tail(sline, all_mask,
 383                                                     hunk_begin, j);
 384                                la = (la + context < cnt) ?
 385                                        (la + context) : cnt;
 386                                while (j <= --la) {
 387                                        if (sline[la].flag & mark) {
 388                                                contin = 1;
 389                                                break;
 390                                        }
 391                                }
 392                                if (!contin)
 393                                        break;
 394                                j = la;
 395                        }
 396                }
 397                hunk_end = j;
 398
 399                /* [i..hunk_end) are interesting.  Now is it really
 400                 * interesting?
 401                 */
 402                same_diff = 0;
 403                has_interesting = 0;
 404                for (j = i; j < hunk_end && !has_interesting; j++) {
 405                        unsigned long this_diff = ~sline[j].flag & all_mask;
 406                        struct lline *ll = sline[j].lost_head;
 407                        if (this_diff) {
 408                                /* This has some changes.  Is it the
 409                                 * same as others?
 410                                 */
 411                                if (!same_diff)
 412                                        same_diff = this_diff;
 413                                else if (same_diff != this_diff) {
 414                                        has_interesting = 1;
 415                                        break;
 416                                }
 417                        }
 418                        while (ll && !has_interesting) {
 419                                /* Lost this line from these parents;
 420                                 * who are they?  Are they the same?
 421                                 */
 422                                this_diff = ll->parent_map;
 423                                if (!same_diff)
 424                                        same_diff = this_diff;
 425                                else if (same_diff != this_diff) {
 426                                        has_interesting = 1;
 427                                }
 428                                ll = ll->next;
 429                        }
 430                }
 431
 432                if (!has_interesting) {
 433                        /* This hunk is not that interesting after all */
 434                        for (j = hunk_begin; j < hunk_end; j++)
 435                                sline[j].flag &= ~mark;
 436                }
 437                i = hunk_end;
 438        }
 439
 440        has_interesting = give_context(sline, cnt, num_parent);
 441        return has_interesting;
 442}
 443
 444static void dump_sline(struct sline *sline, int cnt, int num_parent)
 445{
 446        unsigned long mark = (1UL<<num_parent);
 447        int i;
 448        int lno = 0;
 449
 450        while (1) {
 451                struct sline *sl = &sline[lno];
 452                int hunk_end;
 453                while (lno < cnt && !(sline[lno].flag & mark))
 454                        lno++;
 455                if (cnt <= lno)
 456                        break;
 457                for (hunk_end = lno + 1; hunk_end < cnt; hunk_end++)
 458                        if (!(sline[hunk_end].flag & mark))
 459                                break;
 460                for (i = 0; i <= num_parent; i++) putchar(combine_marker);
 461                printf(" +%d,%d ", lno+1, hunk_end-lno);
 462                for (i = 0; i <= num_parent; i++) putchar(combine_marker);
 463                putchar('\n');
 464                while (lno < hunk_end) {
 465                        struct lline *ll;
 466                        int j;
 467                        sl = &sline[lno++];
 468                        ll = sl->lost_head;
 469                        while (ll) {
 470                                for (j = 0; j < num_parent; j++) {
 471                                        if (ll->parent_map & (1UL<<j))
 472                                                putchar('-');
 473                                        else
 474                                                putchar(' ');
 475                                }
 476                                puts(ll->line);
 477                                ll = ll->next;
 478                        }
 479                        for (j = 0; j < num_parent; j++) {
 480                                if ((1UL<<j) & sl->flag)
 481                                        putchar(' ');
 482                                else
 483                                        putchar('+');
 484                        }
 485                        printf("%.*s\n", sl->len, sl->bol);
 486                }
 487        }
 488}
 489
 490static void reuse_combine_diff(struct sline *sline, unsigned long cnt,
 491                               int i, int j)
 492{
 493        /* We have already examined parent j and we know parent i
 494         * and parent j are the same, so reuse the combined result
 495         * of parent j for parent i.
 496         */
 497        unsigned long lno, imask, jmask;
 498        imask = (1UL<<i);
 499        jmask = (1UL<<j);
 500
 501        for (lno = 0; lno < cnt; lno++) {
 502                struct lline *ll = sline->lost_head;
 503                while (ll) {
 504                        if (ll->parent_map & jmask)
 505                                ll->parent_map |= imask;
 506                        ll = ll->next;
 507                }
 508                if (!(sline->flag & jmask))
 509                        sline->flag &= ~imask;
 510                sline++;
 511        }
 512}
 513
 514int show_combined_diff(struct combine_diff_path *elem, int num_parent,
 515                       int dense, const char *header, int show_empty)
 516{
 517        unsigned long size, cnt, lno;
 518        char *result, *cp, *ep;
 519        struct sline *sline; /* survived lines */
 520        int i, show_hunks, shown_header = 0;
 521        char ourtmp_buf[TMPPATHLEN];
 522        char *ourtmp = ourtmp_buf;
 523
 524        /* Read the result of merge first */
 525        if (memcmp(elem->sha1, null_sha1, 20)) {
 526                result = grab_blob(elem->sha1, &size);
 527                write_to_temp_file(ourtmp, result, size);
 528        }
 529        else {
 530                struct stat st;
 531                int fd;
 532                ourtmp = elem->path;
 533                if (0 <= (fd = open(ourtmp, O_RDONLY)) &&
 534                    !fstat(fd, &st)) {
 535                        int len = st.st_size;
 536                        int cnt = 0;
 537
 538                        size = len;
 539                        result = xmalloc(len + 1);
 540                        while (cnt < len) {
 541                                int done = xread(fd, result+cnt, len-cnt);
 542                                if (done == 0)
 543                                        break;
 544                                if (done < 0)
 545                                        die("read error '%s'", ourtmp);
 546                                cnt += done;
 547                        }
 548                        result[len] = 0;
 549                }
 550                else {
 551                        /* deleted file */
 552                        size = 0;
 553                        result = xmalloc(1);
 554                        result[0] = 0;
 555                        ourtmp = "/dev/null";
 556                }
 557                if (0 <= fd)
 558                        close(fd);
 559        }
 560
 561        for (cnt = 0, cp = result; cp - result < size; cp++) {
 562                if (*cp == '\n')
 563                        cnt++;
 564        }
 565        if (result[size-1] != '\n')
 566                cnt++; /* incomplete line */
 567
 568        sline = xcalloc(cnt, sizeof(*sline));
 569        ep = result;
 570        sline[0].bol = result;
 571        for (lno = 0, cp = result; cp - result < size; cp++) {
 572                if (*cp == '\n') {
 573                        sline[lno].lost_tail = &sline[lno].lost_head;
 574                        sline[lno].len = cp - sline[lno].bol;
 575                        sline[lno].flag = (1UL<<num_parent) - 1;
 576                        lno++;
 577                        if (lno < cnt)
 578                                sline[lno].bol = cp + 1;
 579                }
 580        }
 581        if (result[size-1] != '\n') {
 582                sline[cnt-1].lost_tail = &sline[cnt-1].lost_head;
 583                sline[cnt-1].len = size - (sline[cnt-1].bol - result);
 584                sline[cnt-1].flag = (1UL<<num_parent) - 1;
 585        }
 586
 587        for (i = 0; i < num_parent; i++) {
 588                int j;
 589                for (j = 0; j < i; j++) {
 590                        if (!memcmp(elem->parent_sha1[i],
 591                                    elem->parent_sha1[j], 20)) {
 592                                reuse_combine_diff(sline, cnt, i, j);
 593                                break;
 594                        }
 595                }
 596                if (i <= j)
 597                        combine_diff(elem->parent_sha1[i], ourtmp, sline,
 598                                     cnt, i);
 599        }
 600
 601        show_hunks = make_hunks(sline, cnt, num_parent, dense);
 602
 603        if (header && (show_hunks || show_empty)) {
 604                shown_header++;
 605                puts(header);
 606        }
 607        if (show_hunks) {
 608                printf("diff --%s ", dense ? "cc" : "combined");
 609                if (quote_c_style(elem->path, NULL, NULL, 0))
 610                        quote_c_style(elem->path, NULL, stdout, 0);
 611                else
 612                        printf("%s", elem->path);
 613                putchar('\n');
 614                dump_sline(sline, cnt, num_parent);
 615        }
 616        if (ourtmp == ourtmp_buf)
 617                unlink(ourtmp);
 618        free(result);
 619
 620        for (i = 0; i < cnt; i++) {
 621                if (sline[i].lost_head) {
 622                        struct lline *ll = sline[i].lost_head;
 623                        while (ll) {
 624                                struct lline *tmp = ll;
 625                                ll = ll->next;
 626                                free(tmp);
 627                        }
 628                }
 629        }
 630        free(sline);
 631        return shown_header;
 632}
 633
 634int diff_tree_combined_merge(const unsigned char *sha1,
 635                             const char *header,
 636                             int show_empty_merge, int dense)
 637{
 638        struct commit *commit = lookup_commit(sha1);
 639        struct diff_options diffopts;
 640        struct commit_list *parents;
 641        struct combine_diff_path *p, *paths = NULL;
 642        int num_parent, i, num_paths;
 643
 644        diff_setup(&diffopts);
 645        diffopts.output_format = DIFF_FORMAT_NO_OUTPUT;
 646        diffopts.recursive = 1;
 647
 648        /* count parents */
 649        for (parents = commit->parents, num_parent = 0;
 650             parents;
 651             parents = parents->next, num_parent++)
 652                ; /* nothing */
 653
 654        /* find set of paths that everybody touches */
 655        for (parents = commit->parents, i = 0;
 656             parents;
 657             parents = parents->next, i++) {
 658                struct commit *parent = parents->item;
 659                diff_tree_sha1(parent->object.sha1, commit->object.sha1, "",
 660                               &diffopts);
 661                paths = intersect_paths(paths, i, num_parent);
 662                diff_flush(&diffopts);
 663        }
 664
 665        /* find out surviving paths */
 666        for (num_paths = 0, p = paths; p; p = p->next) {
 667                if (p->len)
 668                        num_paths++;
 669        }
 670        if (num_paths || show_empty_merge) {
 671                for (p = paths; p; p = p->next) {
 672                        if (!p->len)
 673                                continue;
 674                        if (show_combined_diff(p, num_parent, dense, header,
 675                                               show_empty_merge))
 676                                header = NULL;
 677                }
 678        }
 679
 680        /* Clean things up */
 681        while (paths) {
 682                struct combine_diff_path *tmp = paths;
 683                paths = paths->next;
 684                free(tmp);
 685        }
 686        return 0;
 687}