fix for more minor memory leaks

diff --git a/shell.c b/shell.c
index 8c08cf0fb339d293383c3dacb8cdfc805afa3727..cfe372b21379486ea0c7e4d5686c08064c20c279 100644 (file)
--- a/shell.c
+++ b/shell.c
@@ -1,6 +1,7 @@
 #include "cache.h"
 #include "quote.h"
 #include "exec_cmd.h"
+#include "strbuf.h"
 
 static int do_generic_cmd(const char *me, char *arg)
 {
@@ -8,7 +9,7 @@ static int do_generic_cmd(const char *me, char *arg)
 
        if (!arg || !(arg = sq_dequote(arg)))
                die("bad argument");
-       if (strncmp(me, "git-", 4))
+       if (prefixcmp(me, "git-"))
                die("bad command");
 
        my_argv[0] = me + 4;
@@ -18,12 +19,34 @@ static int do_generic_cmd(const char *me, char *arg)
        return execv_git_cmd(my_argv);
 }
 
+static int do_cvs_cmd(const char *me, char *arg)
+{
+       const char *cvsserver_argv[3] = {
+               "cvsserver", "server", NULL
+       };
+       const char *oldpath = getenv("PATH");
+       struct strbuf newpath = STRBUF_INIT;
+
+       if (!arg || strcmp(arg, "server"))
+               die("git-cvsserver only handles server: %s", arg);
+
+       strbuf_addstr(&newpath, git_exec_path());
+       strbuf_addch(&newpath, ':');
+       strbuf_addstr(&newpath, oldpath);
+
+       setenv("PATH", strbuf_detach(&newpath, NULL), 1);
+
+       return execv_git_cmd(cvsserver_argv);
+}
+
+
 static struct commands {
        const char *name;
        int (*exec)(const char *me, char *arg);
 } cmd_list[] = {
        { "git-receive-pack", do_generic_cmd },
        { "git-upload-pack", do_generic_cmd },
+       { "cvs", do_cvs_cmd },
        { NULL },
 };
 
@@ -32,8 +55,10 @@ int main(int argc, char **argv)
        char *prog;
        struct commands *cmd;
 
+       if (argc == 2 && !strcmp(argv[1], "cvs server"))
+               argv--;
        /* We want to see "-c cmd args", and nothing else */
-       if (argc != 3 || strcmp(argv[1], "-c"))
+       else if (argc != 3 || strcmp(argv[1], "-c"))
                die("What do you think I am? A shell?");
 
        prog = argv[2];