add generic most-recently-used list

There are a few places in Git that would benefit from a fast
most-recently-used cache (e.g., the list of packs, which we
search linearly but would like to order based on locality).
This patch introduces a generic list that can be used to
store arbitrary pointers in most-recently-used order.

The implementation is just a doubly-linked list, where
"marking" an item as used moves it to the front of the list.
Insertion and marking are O(1), and iteration is O(n).

There's no lookup support provided; if you need fast
lookups, you are better off with a different data structure
in the first place.

There is also no deletion support. This would not be hard to
do, but it's not necessary for handling pack structs, which
are created and never removed.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/Makefile b/Makefile
index c1e88dfcdd53f46ea742212f15863e63ef5e1d65..3b82ce00700a5d5fbaf8ca27c0411f7431f3e9a9 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -751,6 +751,7 @@ LIB_OBJS += merge.o
 LIB_OBJS += merge-blobs.o
 LIB_OBJS += merge-recursive.o
 LIB_OBJS += mergesort.o
+LIB_OBJS += mru.o
 LIB_OBJS += name-hash.o
 LIB_OBJS += notes.o
 LIB_OBJS += notes-cache.o

diff --git a/mru.c b/mru.c
new file mode 100644 (file)
index 0000000..9dedae0
--- /dev/null
+++ b/mru.c
@@ -0,0 +1,50 @@
+#include "cache.h"
+#include "mru.h"
+
+void mru_append(struct mru *mru, void *item)
+{
+       struct mru_entry *cur = xmalloc(sizeof(*cur));
+       cur->item = item;
+       cur->prev = mru->tail;
+       cur->next = NULL;
+
+       if (mru->tail)
+               mru->tail->next = cur;
+       else
+               mru->head = cur;
+       mru->tail = cur;
+}
+
+void mru_mark(struct mru *mru, struct mru_entry *entry)
+{
+       /* If we're already at the front of the list, nothing to do */
+       if (mru->head == entry)
+               return;
+
+       /* Otherwise, remove us from our current slot... */
+       if (entry->prev)
+               entry->prev->next = entry->next;
+       if (entry->next)
+               entry->next->prev = entry->prev;
+       else
+               mru->tail = entry->prev;
+
+       /* And insert us at the beginning. */
+       entry->prev = NULL;
+       entry->next = mru->head;
+       if (mru->head)
+               mru->head->prev = entry;
+       mru->head = entry;
+}
+
+void mru_clear(struct mru *mru)
+{
+       struct mru_entry *p = mru->head;
+
+       while (p) {
+               struct mru_entry *to_free = p;
+               p = p->next;
+               free(to_free);
+       }
+       mru->head = mru->tail = NULL;
+}

diff --git a/mru.h b/mru.h
new file mode 100644 (file)
index 0000000..42e4aea
--- /dev/null
+++ b/mru.h
@@ -0,0 +1,45 @@
+#ifndef MRU_H
+#define MRU_H
+
+/**
+ * A simple most-recently-used cache, backed by a doubly-linked list.
+ *
+ * Usage is roughly:
+ *
+ *   // Create a list.  Zero-initialization is required.
+ *   static struct mru cache;
+ *   mru_append(&cache, item);
+ *   ...
+ *
+ *   // Iterate in MRU order.
+ *   struct mru_entry *p;
+ *   for (p = cache.head; p; p = p->next) {
+ *     if (matches(p->item))
+ *             break;
+ *   }
+ *
+ *   // Mark an item as used, moving it to the front of the list.
+ *   mru_mark(&cache, p);
+ *
+ *   // Reset the list to empty, cleaning up all resources.
+ *   mru_clear(&cache);
+ *
+ * Note that you SHOULD NOT call mru_mark() and then continue traversing the
+ * list; it reorders the marked item to the front of the list, and therefore
+ * you will begin traversing the whole list again.
+ */
+
+struct mru_entry {
+       void *item;
+       struct mru_entry *prev, *next;
+};
+
+struct mru {
+       struct mru_entry *head, *tail;
+};
+
+void mru_append(struct mru *mru, void *item);
+void mru_mark(struct mru *mru, struct mru_entry *entry);
+void mru_clear(struct mru *mru);
+
+#endif /* MRU_H */