assume parse_commit checks commit->object.parsed

The parse_commit function will check the "parsed" flag of
the object and do nothing if it is set. There is no need
for callers to check the flag themselves, and doing so only
clutters the code.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/builtin/blame.c b/builtin/blame.c
index 079dcd3407881ce0ea988c3f487faf8ca6d3e5d2..4d254665094322196e6dbb8a3da3009b4b3966db 100644 (file)
--- a/builtin/blame.c
+++ b/builtin/blame.c
@@ -1554,8 +1554,7 @@ static void assign_blame(struct scoreboard *sb, int opt)
                 */
                origin_incref(suspect);
                commit = suspect->commit;
                 */
                origin_incref(suspect);
                commit = suspect->commit;

-               if (!commit->object.parsed)
-                       parse_commit(commit);
+               parse_commit(commit);

                if (reverse ||
                    (!(commit->object.flags & UNINTERESTING) &&
                     !(revs->max_age != -1 && commit->date < revs->max_age)))
                if (reverse ||
                    (!(commit->object.flags & UNINTERESTING) &&
                     !(revs->max_age != -1 && commit->date < revs->max_age)))

diff --git a/builtin/name-rev.c b/builtin/name-rev.c
index 0aaa19e4abeb462b2f1d05d5e03aa29bee810db8..26f40330e30842ffb9995f32be9604bec9e1f940 100644 (file)
--- a/builtin/name-rev.c
+++ b/builtin/name-rev.c
@@ -27,8 +27,7 @@ static void name_rev(struct commit *commit,
        struct commit_list *parents;
        int parent_number = 1;
 
        struct commit_list *parents;
        int parent_number = 1;
 

-       if (!commit->object.parsed)
-               parse_commit(commit);
+       parse_commit(commit);

 
        if (commit->date < cutoff)
                return;
 
        if (commit->date < cutoff)
                return;

diff --git a/builtin/show-branch.c b/builtin/show-branch.c
index 9788eb115beb2ab5663bd1d318ce411099589321..3afc79b2c3062ccd6ce3e61dadaac9fe33ff9575 100644 (file)
--- a/builtin/show-branch.c
+++ b/builtin/show-branch.c
@@ -227,8 +227,7 @@ static void join_revs(struct commit_list **list_p,
                        parents = parents->next;
                        if ((this_flag & flags) == flags)
                                continue;
                        parents = parents->next;
                        if ((this_flag & flags) == flags)
                                continue;

-                       if (!p->object.parsed)
-                               parse_commit(p);
+                       parse_commit(p);

                        if (mark_seen(p, seen_p) && !still_interesting)
                                extra--;
                        p->object.flags |= flags;
                        if (mark_seen(p, seen_p) && !still_interesting)
                                extra--;
                        p->object.flags |= flags;

diff --git a/fetch-pack.c b/fetch-pack.c
index 6684348c0ec9ea742eb98666b56a0bfcef316560..86b69775e329565fe1acf995aa122030e1b5e90f 100644 (file)
--- a/fetch-pack.c
+++ b/fetch-pack.c
@@ -46,9 +46,8 @@ static void rev_list_push(struct commit *commit, int mark)
        if (!(commit->object.flags & mark)) {
                commit->object.flags |= mark;
 
        if (!(commit->object.flags & mark)) {
                commit->object.flags |= mark;
 

-               if (!(commit->object.parsed))
-                       if (parse_commit(commit))
-                               return;
+               if (parse_commit(commit))
+                       return;

 
                prio_queue_put(&rev_list, commit);
 
 
                prio_queue_put(&rev_list, commit);
 


@@ -127,8 +126,7 @@ static const unsigned char *get_rev(void)
                        return NULL;
 
                commit = prio_queue_get(&rev_list);
                        return NULL;
 
                commit = prio_queue_get(&rev_list);

-               if (!commit->object.parsed)
-                       parse_commit(commit);
+               parse_commit(commit);

                parents = commit->parents;
 
                commit->object.flags |= POPPED;
                parents = commit->parents;
 
                commit->object.flags |= POPPED;