t3200: do not open a HTML manual page when DEFAULT_MAN_FORMAT is html
authorJohannes Sixt <j6t@kdbg.org>
Sat, 26 Oct 2013 18:48:46 +0000 (20:48 +0200)
committerJunio C Hamano <gitster@pobox.com>
Wed, 30 Oct 2013 19:19:57 +0000 (12:19 -0700)
We have the build configuration option DEFAULT_MAN_FORMAT to choose a
format different from man pages to be used by 'git help' when no format
is requested explicitly. Since 65db0443 (Set the default help format to
html for msys builds, 2013-06-04) we use html on Windows by default.

There is one test in t3200-branch.sh that invokes a help page. The
intent of the redirections applied to the command invocation is to avoid
that the man page viewer interferes with the automated test. But when
the default format is not "man", this does not have the intended effect,
and the HTML manual page is opened during the test run. Request "man"
format explicitly to keep the test silent.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t3200-branch.sh
index 55c9ab0b6a5c65aacdb3ef6107c3417d7bdc4e00..bc117aaf33f07c9864db754cdf499c32e42937d3 100755 (executable)
@@ -17,7 +17,7 @@ test_expect_success 'prepare a trivial repository' '
        HEAD=$(git rev-parse --verify HEAD)'
 
 test_expect_success 'git branch --help should not have created a bogus branch' '
-       test_might_fail git branch --help </dev/null >/dev/null 2>/dev/null &&
+       test_might_fail git branch --man --help </dev/null >/dev/null 2>&1 &&
        test_path_is_missing .git/refs/heads/--help
 '