files-backend: use `die("BUG: ...")`, not `die("internal error: ...")`

The former is by far more common in our codebase.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/refs/files-backend.c b/refs/files-backend.c
index cb1f528cbeec47970dca1089121bb0280858896c..fa5d2b6f08cb4b80dda336bbf08a5b85107d39b2 100644 (file)
--- a/refs/files-backend.c
+++ b/refs/files-backend.c
@@ -105,7 +105,7 @@ static void clear_packed_ref_cache(struct files_ref_store *refs)
                struct packed_ref_cache *packed_refs = refs->packed;
 
                if (packed_refs->lock)
                struct packed_ref_cache *packed_refs = refs->packed;
 
                if (packed_refs->lock)

-                       die("internal error: packed-ref cache cleared while locked");
+                       die("BUG: packed-ref cache cleared while locked");

                refs->packed = NULL;
                release_packed_ref_cache(packed_refs);
        }
                refs->packed = NULL;
                release_packed_ref_cache(packed_refs);
        }


@@ -397,7 +397,7 @@ static void add_packed_ref(struct files_ref_store *refs,
        struct packed_ref_cache *packed_ref_cache = get_packed_ref_cache(refs);
 
        if (!packed_ref_cache->lock)
        struct packed_ref_cache *packed_ref_cache = get_packed_ref_cache(refs);
 
        if (!packed_ref_cache->lock)

-               die("internal error: packed refs not locked");
+               die("BUG: packed refs not locked");

        add_ref_entry(get_packed_ref_dir(packed_ref_cache),
                      create_ref_entry(refname, oid, REF_ISPACKED, 1));
 }
        add_ref_entry(get_packed_ref_dir(packed_ref_cache),
                      create_ref_entry(refname, oid, REF_ISPACKED, 1));
 }


@@ -1324,7 +1324,7 @@ static int commit_packed_refs(struct files_ref_store *refs)
        files_assert_main_repository(refs, "commit_packed_refs");
 
        if (!packed_ref_cache->lock)
        files_assert_main_repository(refs, "commit_packed_refs");
 
        if (!packed_ref_cache->lock)

-               die("internal error: packed-refs not locked");
+               die("BUG: packed-refs not locked");

 
        out = fdopen_lock_file(packed_ref_cache->lock, "w");
        if (!out)
 
        out = fdopen_lock_file(packed_ref_cache->lock, "w");
        if (!out)


@@ -1367,7 +1367,7 @@ static void rollback_packed_refs(struct files_ref_store *refs)
        files_assert_main_repository(refs, "rollback_packed_refs");
 
        if (!packed_ref_cache->lock)
        files_assert_main_repository(refs, "rollback_packed_refs");
 
        if (!packed_ref_cache->lock)

-               die("internal error: packed-refs not locked");
+               die("BUG: packed-refs not locked");

        rollback_lock_file(packed_ref_cache->lock);
        packed_ref_cache->lock = NULL;
        release_packed_ref_cache(packed_ref_cache);
        rollback_lock_file(packed_ref_cache->lock);
        packed_ref_cache->lock = NULL;
        release_packed_ref_cache(packed_ref_cache);