t7061: status --ignored should search untracked dirs
authorSamuel Lijin <sxlijin@gmail.com>
Thu, 18 May 2017 08:21:50 +0000 (04:21 -0400)
committerJunio C Hamano <gitster@pobox.com>
Mon, 22 May 2017 03:06:52 +0000 (12:06 +0900)
Per eb8c5b87, `status --ignored` by design does not list ignored files
if they are in a directory which contains only ignored and untracked
files (which is itself considered to be untracked) without `-uall`. This
does not make sense for `--ignored`, which claims to "Show ignored files
as well."

Thus we revisit eb8c5b87 and decide that for such directories, `status
--ignored` will list the directory as untracked *and* list all ignored
files within said directory even without `-uall`.

Signed-off-by: Samuel Lijin <sxlijin@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t7061-wtstatus-ignore.sh
index cdc0747bf01b0598a2e864073887896162815019..15e7592b6b07b00176d0672ade2d2e05b12abdf9 100755 (executable)
@@ -9,9 +9,10 @@ cat >expected <<\EOF
 ?? actual
 ?? expected
 ?? untracked/
+!! untracked/ignored
 EOF
 
-test_expect_success 'status untracked directory with --ignored' '
+test_expect_failure 'status untracked directory with --ignored' '
        echo "ignored" >.gitignore &&
        mkdir untracked &&
        : >untracked/ignored &&
@@ -20,7 +21,7 @@ test_expect_success 'status untracked directory with --ignored' '
        test_cmp expected actual
 '
 
-test_expect_success 'same with gitignore starting with BOM' '
+test_expect_failure 'same with gitignore starting with BOM' '
        printf "\357\273\277ignored\n" >.gitignore &&
        mkdir -p untracked &&
        : >untracked/ignored &&