Finish current packfile during fast-import crash handler
authorShawn O. Pearce <spearce@spearce.org>
Thu, 14 Feb 2008 06:34:43 +0000 (01:34 -0500)
committerJunio C Hamano <gitster@pobox.com>
Sat, 16 Feb 2008 08:47:07 +0000 (00:47 -0800)
If fast-import is in the middle of crashing due to a protocol error
or something like that then it can be very useful to have the mark
table and all objects up until that point be available for a new
import to resume from.

Currently we just close the active packfile, unkeep all of our
newly created packfiles (so they can be deleted), and dump the
marks table to a temporary file.

We don't attempt to update the refs/tags that the process has in
memory as much of that data can be found in the crash report and I'm
not sure it would be the right thing to do under every type of crash.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
fast-import.c
index 117f38c0f1066d3c2627cea7179e0c316372a13e..0d3449f2cef93ae0ece87f4204d5e817d6e62439 100644 (file)
@@ -459,6 +459,10 @@ static void write_crash_report(const char *err)
        fclose(rpt);
 }
 
+static void end_packfile(void);
+static void unkeep_all_packs(void);
+static void dump_marks(void);
+
 static NORETURN void die_nicely(const char *err, va_list params)
 {
        static int zombie;
@@ -472,6 +476,9 @@ static NORETURN void die_nicely(const char *err, va_list params)
        if (!zombie) {
                zombie = 1;
                write_crash_report(message);
+               end_packfile();
+               unkeep_all_packs();
+               dump_marks();
        }
        exit(128);
 }