Andrew's git
/
gitweb.git
/ diff
summary
|
log
|
commit
| diff |
tree
commit
grep
author
committer
pickaxe
?
re
gitweb: Use underscore instead of hyphen to separate words in HTTP headers names
author
Jakub Narebski
<jnareb@gmail.com>
Tue, 22 Aug 2006 14:55:34 +0000
(16:55 +0200)
committer
Junio C Hamano
<junkio@cox.net>
Tue, 22 Aug 2006 23:05:09 +0000
(16:05 -0700)
Use underscore (which will be turned into hyphen) to separate words in
HTTP header names, in keys to CGI header() method, consistently.
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
gitweb/gitweb.perl
patch
|
blob
|
history
raw
|
patch
|
inline
| side by side (parent:
952c65f
)
diff --git
a/gitweb/gitweb.perl
b/gitweb/gitweb.perl
index 63dc477eab81b9bea57e44910e34c2953de8af85..c4a4f7ffd7ea74b60013dddbc6acc23723e5f5e5 100755
(executable)
--- a/
gitweb/gitweb.perl
+++ b/
gitweb/gitweb.perl
@@
-2198,7
+2198,8
@@
sub git_blob_plain {
$save_as .= '.txt';
}
$save_as .= '.txt';
}
- print $cgi->header(-type => "$type", '-content-disposition' => "inline; filename=\"$save_as\"");
+ print $cgi->header(-type => "$type",
+ -content_disposition => "inline; filename=\"$save_as\"");
undef $/;
binmode STDOUT, ':raw';
print <$fd>;
undef $/;
binmode STDOUT, ':raw';
print <$fd>;
@@
-2382,8
+2383,8
@@
sub git_snapshot {
my $filename = basename($project) . "-$hash.tar.$suffix";
print $cgi->header(-type => 'application/x-tar',
my $filename = basename($project) . "-$hash.tar.$suffix";
print $cgi->header(-type => 'application/x-tar',
- -content
-
encoding => $ctype,
-
'-content-disposition'
=> "inline; filename=\"$filename\"",
+ -content
_
encoding => $ctype,
+
-content_disposition
=> "inline; filename=\"$filename\"",
-status => '200 OK');
open my $fd, "-|", "$GIT tar-tree $hash \'$project\' | $command" or
-status => '200 OK');
open my $fd, "-|", "$GIT tar-tree $hash \'$project\' | $command" or
@@
-2701,7
+2702,7
@@
sub git_commitdiff_plain {
print $cgi->header(-type => "text/plain",
-charset => 'utf-8',
print $cgi->header(-type => "text/plain",
-charset => 'utf-8',
-
'-content-disposition'
=> "inline; filename=\"git-$hash.patch\"");
+
-content_disposition
=> "inline; filename=\"git-$hash.patch\"");
my %ad = parse_date($co{'author_epoch'}, $co{'author_tz'});
my $comment = $co{'comment'};
print "From: $co{'author'}\n" .
my %ad = parse_date($co{'author_epoch'}, $co{'author_tz'});
my $comment = $co{'comment'};
print "From: $co{'author'}\n" .