t5801: "VAR=VAL shell_func args" is forbidden
authorJunio C Hamano <gitster@pobox.com>
Thu, 25 Apr 2013 17:18:37 +0000 (10:18 -0700)
committerJunio C Hamano <gitster@pobox.com>
Thu, 25 Apr 2013 17:18:37 +0000 (10:18 -0700)
It is not a portable expectation that a single-shot environment
variable assignment works when calling a shell function, not a
command.

Set and export the variable before calling "test_must_fail git push"
instead. This change would not hurt because this is the last
command in the subprocess and the environment will not seep through
to later tests without using a single-shot assignment.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
t/t5801-remote-helpers.sh
index 4dcf744f97718298cb9adec17e44030b520162de..c956abd865b7149742ed85203b3ba73c42b0b39b 100755 (executable)
@@ -118,7 +118,9 @@ test_expect_success 'pushing without refspecs' '
        (cd local2 &&
        echo content >>file &&
        git commit -a -m ten &&
-       GIT_REMOTE_TESTGIT_REFSPEC="" test_must_fail git push 2>../error) &&
+       GIT_REMOTE_TESTGIT_REFSPEC="" &&
+       export GIT_REMOTE_TESTGIT_REFSPEC &&
+       test_must_fail git push 2>../error) &&
        grep "remote-helper doesn.t support push; refspec needed" error
 '